[HOLD for payment 2023-08-02] [$1000] Web - #admin is highlighted in LHN but shows Concierge report screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create new account
2. Click on + icon and select New workspace option
3. Check the LHN and report screen

Expected Result:

Concierge should be highlighted in LHN

Actual Result:

#admin is highlighted in LHN but shows Concierge report screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-5

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-16.at.3.40.08.PM.mov

Recording.3233.mp4

Expensify/Expensify Issue URL:

Issue reported by: @gadhiyamanan

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686910566735839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01975cb777161dce5e
• Upwork Job ID: 1673275742488936448
• Last Price Increase: 2023-07-03

[esh-g]

Proposal

Please re-state the problem

#admin is highlighted in LHN but shows Concierge report screen on newly created account.

What is the root cause of that problem?

The root cause is that when the Workspace is created, we have to navigate to two screens:

1. #admin chat in Report Screen
2. Workspace details page in RHP

App/src/libs/actions/Policy.js

Lines 1045 to 1049 in 6183609

	// Get the reportID associated with the newly created #admins room and route the user to that chat
	const routeKey = lodashGet(navigationRef.getState(), 'routes[0].state.routes[0].key');
	Navigation.setParams({reportID: adminsChatReportID}, routeKey);
	Navigation.navigate(ROUTES.getWorkspaceInitialRoute(policyID));

Here we just set the route params to the reportID of the admins chat and only navigate to the RHP details page because this code was written before the navigation refactor and I think we couldn't navigate to both at once at that time.

But since we are only updating the route params, it is not causing the ReportScreenWrapper to update because that is set to update only if the reportID becomes null and therefore, the URL changes to the adminReportID but the actual ReportScreen doesn't change.

What changes do you think we should make to solve this problem?

We can just navigate to both the routes using Navigation.navigate for both routes so that it looks something like this:

if (shouldNavigateToAdminChat) {
            Navigation.navigate(ROUTES.getReportRoute(adminsChatReportID));
}

Navigation.navigate(ROUTES.getWorkspaceInitialRoute(policyID));

Notice that I'm also adding a parameter to the createWorkspace method called shouldNavigateToAdminChat which can be set to false on small screens because navigating to admin on small screen pushes the workspace before and after the admin chat. This prop can be passed in FloatingActionButtonAndPopover.js as !this.props.isSmallScreenWidth.

Result

Screen.Recording.2023-06-23.at.2.05.38.PM.mov

What other approach did you explore?

I also tried having the ReportScreenWrapper to update on route change but that exceeds the maximum depth of updates react is capable of.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01975cb777161dce5e

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[twisterdotcom]

@abdulrahuman5196 - I think @esh-g's proposal looks good. At least the outcome video seems correct anyway. Wonder if we could get this one assigned quickly!

[abdulrahuman5196]

Sure will check on this today and update

[abdulrahuman5196]

@esh-g I am not sure if i am aligned to make 2 navigations to solve this issue. Consider small screen devices it will add 2 navigations on the navigation stack, how will it behave there?

[esh-g]

Notice that I'm also adding a parameter to the createWorkspace method called shouldNavigateToAdminChat which can be set to false on small screens because navigating to admin on small screen pushes the workspace before and after the admin chat. This prop can be passed in FloatingActionButtonAndPopover.js as !this.props.isSmallScreenWidth.

@abdulrahuman5196 That is why I have added these lines to the proposal. I know that it will push unexpected screens for small screen devices, that is why I'm proposing to only navigate to admins chat on full screen devices as small screen devices can navigate to only one screen at a time.

[esh-g]

@abdulrahuman5196 Should I provide a branch from my fork to test with for these changes?

[twisterdotcom]

I am OOO! Adding another BZ for the week.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[esh-g]

@abdulrahuman5196 This is how it looks on small screens:

Screen.Recording.2023-06-28.at.9.49.06.PM.mov

And this is the change I was mentioning in my proposal of passing a navigateToAdminChat as false for small screens:
From this:

App/src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

Line 239 in ecfcd83

onSelected: () => this.interceptAnonymousUser(() => Policy.createWorkspace()),

To this:

onSelected: () => this.interceptAnonymousUser(() => Policy.createWorkspace('', false, '', false, !this.props.isSmallScreenWidth)),

[aldo-expensify]

Thanks all, assigning @esh-g to implement proposal

[melvin-bot]

📣 @abdulrahuman5196 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[esh-g]

Thanks for assigning me! 🚀
PR is here: #22619
cc @abdulrahuman5196

[melvin-bot]

@twisterdotcom, @abdulrahuman5196, @esh-g, @aldo-expensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aldo-expensify]

@esh-g the PR is running into conflicts now. What is the current state?

[esh-g]

@aldo-expensify I was waiting for @abdulrahuman5196 to test a comment I left 4 days ago... I'm sorry for not bumping sooner.
I will resolve all the conflicts today

[aldo-expensify]

PR merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.45-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Navigate to #admin on workspace creation #22619

If no regressions arise, payment will be issued on 2023-08-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @esh-g requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

This was caused during navigation refractor.

Determine if we should create a regression test for this bug.

yes

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Login from an account with no workspace (or delete all workspaces)
2. Click on the + icon and create new workspace.
3. On fullscreen, verify that we navigate to #admins page report and also to the workspace details on the right.
4. On Small screen, verify that we are not shown the admin chat but are navigated to the details of the workspace.

@twisterdotcom

[twisterdotcom]

Payment summary:

@abdulrahuman5196 paid $1000 here: https://www.upwork.com/nx/wm/workroom/34164769/overview
@esh-g paid $1000 here: https://www.upwork.com/nx/wm/workroom/34162339/overview
@gadhiyamanan paid $250 here: https://www.upwork.com/nx/wm/workroom/34347173/overview

Internal TestRail issue: https://github.com/Expensify/Expensify/issues/304920