[Awaiting Payment][$1000] Web - URL preview not removed when editing a chat #21191

kbecciv · 2023-06-21T11:41:55Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Go to any chat
Send website URL (ex. google.com)
Observe the site preview thumbnail
Hover over message > click Edit Comment > write a message
Observe the URL preview remains

Expected Result:

The preview should be gone after editing the message

Actual Result:

Preview is visible after editing the message

Workaround:

Uknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.27-6

Reproducible in staging?: y

Reproducible in production?: y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-14.at.12.54.33.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @niravkakadiya25

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686727685589039

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0164e3fa7f55938949
Upwork Job ID: 1671601917583003648
Last Price Increase: 2023-07-28

melvin-bot · 2023-06-21T11:42:00Z

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-06-21T11:42:02Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

StevenKKC · 2023-06-21T14:19:19Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

After editing the link to a simple message, the site preview does not disappear.

What is the root cause of that problem?

The site preview for the link is displayed in the LinkPreviewer.

App/src/pages/home/report/ReportActionItem.js

Lines 349 to 353 in 0b7455f

    
           {!_.isEmpty(props.action.linkMetadata) && ( 
        
               <View style={props.draftMessage ? styles.chatItemReactionsDraftRight : {}}> 
        
                   <LinkPreviewer linkMetadata={_.filter(props.action.linkMetadata, (item) => !_.isEmpty(item))} /> 
        
               </View> 
        
           )}

After editing the link, the app sends ExpandURLPreview API to update site preview.

App/src/pages/home/report/ReportActionItem.js

Lines 139 to 147 in 0b7455f

    
           useEffect(() => { 
        
               const urls = ReportActionsUtils.extractLinksFromMessageHtml(props.action); 
        
               if (_.isEqual(downloadedPreviews.current, urls) || props.action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) { 
        
                   return; 
        
               } 
        
               downloadedPreviews.current = urls; 
        
               Report.expandURLPreview(props.report.reportID, props.action.reportActionID); 
        
           }, [props.action, props.report.reportID]);

But for a simple message, the API returns empty onyxData, and the linkMetadata is not updated accordingly.
This is the root cause that the site preview does not disappear.

What changes do you think we should make in order to solve the problem?

If message is edited, we should update linkMetadata.

Following case should be considered.
If user A send a message 'google.com' to user B, user A and user B will both see the google preview.
Then, if user A edits a message to simple text or other link, user B will see the updated message, but the link preview will not be updated.

Therefore, I think it's best to clear linkMetadata in useEffects.

    useEffect(() => {
        const urls = ReportActionsUtils.extractLinksFromMessageHtml(props.action);
+       if (_.isEmpty(urls) && props.action.linkMetadata) {
+           Report.clearURLPreview(props.report.reportID, props.action.reportActionID);
+           return;
+       }
        if (_.isEqual(downloadedPreviews.current, urls) || props.action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
            return;
        }

        // When open report, `downloadedPreviews.current` is empty, and `linkMetadata` maybe not empty, 
        // so clear `linkMetata` only if `downloadedPreviews.current` is not empty and different with `urls`.
+       if (!_.isEmpty(downloadedPreviews.current)) {
+           Report.clearURLPreview(props.report.reportID, props.action.reportActionID);
+       }

        downloadedPreviews.current = urls;
        Report.expandURLPreview(props.report.reportID, props.action.reportActionID);
    }, [props.action, props.report.reportID]);

And add a clearURLPreview function in Report.js.

function clearURLPreview(reportID, reportActionID) {
    Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {
        [reportActionID]: {
            linkMetadata: [],
        },
    });
}

What alternative solutions did you explore? (Optional)

None.

hungvu193 · 2023-06-21T15:26:48Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - After edit site link to simple message then also preview is show

What is the root cause of that problem?

We are updating the linkMetaData in here:

App/src/pages/home/report/ReportActionItem.js

Lines 139 to 147 in 0b7455f

    
           useEffect(() => { 
        
               const urls = ReportActionsUtils.extractLinksFromMessageHtml(props.action); 
        
               if (_.isEqual(downloadedPreviews.current, urls) || props.action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) { 
        
                   return; 
        
               } 
        
               downloadedPreviews.current = urls; 
        
               Report.expandURLPreview(props.report.reportID, props.action.reportActionID); 
        
           }, [props.action, props.report.reportID]);

After editing the link to some text, it called Report.expandURLPreview(props.report.reportID, props.action.reportActionID); again, but it's returning empty so our old linkMetaData still persisted which caused this issue.

What changes do you think we should make in order to solve the problem?

In our editReportComment function, we should check if the newComment doesn't have urls, then we should update our linkMetaData in our reportAction to empty.

function editReportComment(reportID, originalReportAction, textForNewComment) {
// or we can create a new function to get html from text.
const urls = ReportActionsUtils.extractLinksFromMessageHtml({message: [{html: htmlForNewComment}]});

// update the linkMetaData if newComment doesn't have the urls.
    if (_.isEmpty(urls)) {
        optimisticReportActions[reportActionID].linkMetadata = [];
    }

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-06-21T19:32:10Z

Job added to Upwork: https://www.upwork.com/jobs/~0164e3fa7f55938949

melvin-bot · 2023-06-21T19:32:14Z

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-06-21T19:32:20Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

Christinadobrzyn · 2023-06-21T19:32:20Z

I can reproduce - adding External label

melvin-bot · 2023-06-23T17:37:10Z

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Christinadobrzyn · 2023-06-23T23:11:19Z

@eVoloshchak can you review the proposals when you have a moment? Thank you!

eVoloshchak · 2023-06-26T20:06:36Z

@StevenKKC's proposal looks good to me!
Both proposals are pretty similar and were posted very closely on terms of time, so let's proceed with the first proposal

🎀👀🎀 C+ reviewed!
cc: @Christinadobrzyn

Christinadobrzyn · 2023-06-26T22:46:32Z

Hey @MonilBhavsar Can you give your thoughts on ^ #21191 (comment)

hungvu193 · 2023-06-27T00:42:15Z

@StevenKKC's proposal looks good to me! Both proposals are pretty similar and were posted very closely on terms of time, so let's proceed with the first proposal

🎀👀🎀 C+ reviewed! cc: @Christinadobrzyn

@eVoloshchak I think the difference between my proposal and Steven is that, my proposal only cleared the preview when there's no url inside our message.
If we always clear our message when editing, this will cause another bug when you edit your message from this link to similar link. IE you edited your message from google.com to google.com hello. So if we already had some urls in our message, let expandURLPreview handle the rest instead of clearing them.

melvin-bot · 2023-06-28T16:00:13Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

MonilBhavsar · 2023-06-29T07:05:53Z

Sorry for delay. Catching up from ooo...
@eVoloshchak I think I agree with @hungvu193 's comment here #21191 (comment)
Could you please take a look

MonilBhavsar · 2023-07-31T11:34:28Z

I have pushed a PR in internal repo. Thank you everyone for good discussion on this issue 🙇

Christinadobrzyn · 2023-07-31T18:44:44Z

back from ooo - I'll take this back @flaviadefaria - thanks for handling it for me.

@MonilBhavsar can we move this to weekly while the PR is under review?

MonilBhavsar · 2023-08-01T06:26:19Z

PR is merged.
And since this was internal, we have one payment for issue reporter - @niravkakadiya25

And add regression tests for URL preview messages -

Send a message with url - expensify.com
Verify link preview is displayed
Edit that message and remove the link - expensify.com
Ensure link preview is also removed
Send a message with two url's - expensify.com and google.com
Verify both link previews are displayed
Edit that message and remove one link - google.com and verify preview of that link is removed
Edit that message and remove another link too - expensify.com and verify preview of that link is removed
Send a message with url - slack.com
Edit that message to expensify.com
Verify link preview is also updated

We can close this issue then

melvin-bot · 2023-08-01T19:47:38Z

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

melvin-bot · 2023-08-01T19:48:09Z

Current assignees @flaviadefaria and @Christinadobrzyn are eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-01T19:48:15Z

Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new.

melvin-bot · 2023-08-01T19:48:48Z

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

Christinadobrzyn · 2023-08-01T20:02:32Z

Sorry for all the labels, trying to get an Upwork job auto-created since the original one for this is closed now. Didn't work.

Manually created a job in Upwork
Internal job- https://www.upwork.com/ab/applicants/1686465413539557376/job-details
External job- https://www.upwork.com/jobs/~01300e05a1b86d26fc

@niravkakadiya25 - I sent you an offer for $250 as reporter - can you please accept so I can pay you?
@eVoloshchak are we paying you through NewExpensify? The payment will be $1000, correct?

Regression test here - https://github.com/Expensify/Expensify/issues/304725

Christinadobrzyn · 2023-08-03T18:01:44Z

Per this comment #21191 (comment)

Paid @niravkakadiya25 $250 as reporter

Closing this GH

kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jun 21, 2023

melvin-bot bot assigned Christinadobrzyn Jun 21, 2023

Christinadobrzyn changed the title ~~Web - After edit site link to simple message then also preview is show~~ Web - URL preview not removed when editing a chat Jun 21, 2023

Christinadobrzyn added the External Added to denote the issue can be worked on by a contributor label Jun 21, 2023

melvin-bot bot changed the title ~~Web - URL preview not removed when editing a chat~~ [$1000] Web - URL preview not removed when editing a chat Jun 21, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 21, 2023

melvin-bot bot assigned eVoloshchak Jun 21, 2023

laurenreidexpensify mentioned this issue Jun 22, 2023

[HOLD for payment 2023-07-10] [$1000] Web - site preview is still visible after flag as intimidation #21195

Closed

6 tasks

Christinadobrzyn added the Engineering label Jun 23, 2023

melvin-bot bot assigned MonilBhavsar Jun 23, 2023

melvin-bot bot added the Overdue label Jun 23, 2023

melvin-bot bot added Overdue and removed Overdue labels Jun 23, 2023

melvin-bot bot removed the Overdue label Jun 26, 2023

MonilBhavsar added the Reviewing Has a PR in review label Jul 31, 2023

MonilBhavsar added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Aug 1, 2023

MonilBhavsar changed the title ~~[$1000] Web - URL preview not removed when editing a chat~~ [Awaiting Payment][$1000] Web - URL preview not removed when editing a chat Aug 1, 2023

MonilBhavsar added Weekly KSv2 and removed Daily KSv2 labels Aug 1, 2023

Christinadobrzyn added Internal Requires API changes or must be handled by Expensify staff and removed Help Wanted Apply this label when an issue is open to proposals by contributors Internal Requires API changes or must be handled by Expensify staff labels Aug 1, 2023

Christinadobrzyn added External Added to denote the issue can be worked on by a contributor and removed Internal Requires API changes or must be handled by Expensify staff labels Aug 1, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 1, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 1, 2023

Christinadobrzyn added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Aug 1, 2023

Christinadobrzyn closed this as completed Aug 3, 2023

hungvu193 mentioned this issue Aug 17, 2023

Chat - Link preview doesn't update after editing link #24665

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Awaiting Payment][$1000] Web - URL preview not removed when editing a chat #21191

[Awaiting Payment][$1000] Web - URL preview not removed when editing a chat #21191

kbecciv commented Jun 21, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023 •

edited by Christinadobrzyn

Loading

StevenKKC commented Jun 21, 2023 •

edited

Loading

hungvu193 commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

Christinadobrzyn commented Jun 21, 2023

melvin-bot bot commented Jun 23, 2023

Christinadobrzyn commented Jun 23, 2023

eVoloshchak commented Jun 26, 2023

Christinadobrzyn commented Jun 26, 2023

hungvu193 commented Jun 27, 2023 •

edited

Loading

melvin-bot bot commented Jun 28, 2023

MonilBhavsar commented Jun 29, 2023

MonilBhavsar commented Jul 31, 2023

Christinadobrzyn commented Jul 31, 2023

MonilBhavsar commented Aug 1, 2023 •

edited

Loading

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

Christinadobrzyn commented Aug 1, 2023

Christinadobrzyn commented Aug 3, 2023

[Awaiting Payment][$1000] Web - URL preview not removed when editing a chat #21191

[Awaiting Payment][$1000] Web - URL preview not removed when editing a chat #21191

Comments

kbecciv commented Jun 21, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023 • edited by Christinadobrzyn Loading

Bug0 Triage Checklist (Main S/O)

StevenKKC commented Jun 21, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

hungvu193 commented Jun 21, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

melvin-bot bot commented Jun 21, 2023

Christinadobrzyn commented Jun 21, 2023

melvin-bot bot commented Jun 23, 2023

Christinadobrzyn commented Jun 23, 2023

eVoloshchak commented Jun 26, 2023

Christinadobrzyn commented Jun 26, 2023

hungvu193 commented Jun 27, 2023 • edited Loading

melvin-bot bot commented Jun 28, 2023

MonilBhavsar commented Jun 29, 2023

MonilBhavsar commented Jul 31, 2023

Christinadobrzyn commented Jul 31, 2023

MonilBhavsar commented Aug 1, 2023 • edited Loading

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

melvin-bot bot commented Aug 1, 2023

Christinadobrzyn commented Aug 1, 2023

Christinadobrzyn commented Aug 3, 2023

kbecciv commented Jun 21, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Jun 21, 2023 •

edited by Christinadobrzyn

Loading

StevenKKC commented Jun 21, 2023 •

edited

Loading

hungvu193 commented Jun 27, 2023 •

edited

Loading

MonilBhavsar commented Aug 1, 2023 •

edited

Loading