[HOLD https://github.com/Expensify/App/pull/20512 $1000] Web - New tooltip is not displayed over workspace direct chats and general workspace chat name

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #20276

Action Performed:

1. Login to NewDot with account with workspace with several members
2. Hover over workspace direct chat user names and icons (and over general workspace chat)

Expected Result:

New tooltip should be displayed

Actual Result:

Tooltip is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6091706_video_55__2_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01443ce644ff2fc4f2
• Upwork Job ID: 1671866330621509632
• Last Price Increase: 2023-06-22

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[isagoico]

Issue found while executing PR #20276

[iwiznia]

@puneetlath @fedirjh is this something we missed on #20276 or is this how it is supposed to work? I assume the former...

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[fedirjh]

is this something we missed

@iwiznia I think that when we hover over a user's avatar and email, it should display a new tooltip. However, I am not aware of any specific details regarding the workspace itself.

[iwiznia]

Yeah, I don't see any mention in the OG issue of other entries in the LHN that are not DMs... but our LHN has a lot of things that are not DMs. So the question is: do we want to show a tooltip for all the other cases or not? I'd assume we do want to do that, though not sure what the tooltip would show.

[muttmuure]

• Are we sure that this isn't restricted to only the blank unread chats that appear when someone looks you up on New Expensify?
• If it is that, I think we plan to remove that behavior. Therefore it might seem silly to fix a bug with something that might not be there.
• If this is something more broad, as in all DMs in Workspaces, I agree this is a bug that we should fix.

[iwiznia]

Are we sure that this isn't restricted to only the blank unread chats that appear when someone looks you up on New Expensify?

I don't get this... can you rephrase? What is a blank unread chat?

If this is something more broad, as in all DMs in Workspaces, I agree this is a bug that we should fix.

Very confused by this... the tooltip is not showing for workspace chats, that's the bug.

[muttmuure]

I don't get this... can you rephrase? What is a blank unread chat?

When someone searches your name on New Expensify and clicks your name in Search, a chat with them appears in your LHN

[muttmuure]

My question is:

• Does this affect those kinds of chats I have just described above or does it affect all workspace chats?

It sounds like you are confirming that it affects all workspace chats

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - New tooltip is not displayed over workspace direct chats and general workspace chat name

What is the root cause of that problem?

There are 2 issue here

1. New tooltip is not displayed over workspace direct chats
   Take a look at condition to render SubscriptAvatar component. If it's a WS chat, it will render SubscriptAvatar component in the LHN. And in SubscriptAvatar component, currently we only render normal Tooltip
   

   App/src/components/SubscriptAvatar.js

   Lines 58 to 67 in 4bf2918

   	<Tooltip text={props.mainTooltip}>
   	<View>
   	<Avatar
   	source={props.mainAvatar.source}
   	size={props.size === CONST.AVATAR_SIZE.SMALL ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT}
   	name={props.mainAvatar.name}
   	type={props.mainAvatar.type}
   	/>
   	</View>
   	</Tooltip>

   => We won't see new Tooltip if it's a WS chat.

2. New tooltip is not displayed over general workspace chat name
   In LHN, we're using component DisplayNames to render WS chat name (and other reports too). And if it's a WS chat. It will render fullTitle according to condition here

   App/src/components/LHNOptionsList/OptionRowLHN.js

   Lines 182 to 184 in 4bf2918

   	shouldUseFullTitle={
   	optionItem.isChatRoom || optionItem.isPolicyExpenseChat || optionItem.isTaskReport || optionItem.isThread || optionItem.isMoneyRequestReport
   	}

   
   Then we only render it as Text only in DisplayNames

   App/src/components/DisplayNames/index.js

   Lines 88 to 89 in 4bf2918

   	{this.props.shouldUseFullTitle
   	? this.props.fullTitle

What changes do you think we should make in order to solve the problem?

1. New tooltip is not displayed over workspace direct chats
   To solve this problem, we need to replace old Tooltip by new UserDetailsTooltip with the props accountID={props.mainAvatar.id} here

2. New tooltip is not displayed over general workspace chat name
   Same as above, we need to wrap the text only by UserDetailsTooltip in this line

[thesahindia]

@hoangzinh's proposal looks good to me!

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[muttmuure]

@stitesExpensify ready to assign @hoangzinh

[0xmiros]

This might be fixed in #20512 which updates avatar patterns and tooltip for all types of chats.

[Christinadobrzyn]

hey @thesahindia! Could you check and see if this issue will be fixed with this job? #21683

[hoangzinh]

This might be fixed in #20512 which updates avatar patterns and tooltip for all types of chats.

@0xmiroslav This GH issue has 2 issues. Currently, I think the PR that you mentioned above only fix the 1st issue

[0xmiros]

At least put on hold until that PR is merged and deployed

[melvin-bot]

@stitesExpensify @muttmuure @thesahindia this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[stitesExpensify]

Added a hold for #20512. When that is merged we can come back and see if this is still happening!

[muttmuure]

Not overdue. Held

[stitesExpensify]

hold

[stitesExpensify]

This is the intended functionality right?

[0xmiros]

This is the intended functionality right?

Right

[stitesExpensify]

Cool, then this is fixed!