[HOLD for payment 2023-08-21] [HOLD for #23481] [$1000] mWeb - Sign out - Button hidden under bottom, hard to sign out

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. launch App and login
2. Tap on profile > Settings
3. Tap on Sign Out

Expected Result:

Sign out button should be visible.

Actual Result:

Button hidden under bottom, hard to sign out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.27.2

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6091719_RPReplay_Final1686681051.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f559d55619af61e2
• Upwork Job ID: 1675953147854782464
• Last Price Increase: 2023-07-19

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kevinksullivan]

can't reproduce taking it to slack

https://expensify.slack.com/archives/C049HHMV9SM/p1686757919637879

[melvin-bot]

@kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[kevinksullivan]

bumping slack thread and closing for now

[kbecciv]

Hello @kevinksullivan I'm reopening the issue, because one of the contributor has the same issue with hidden buttons around the app.
Here is the Slack conversation https://expensify.slack.com/archives/C049HHMV9SM/p1686663005982659

IMG_1109.1.MP4

IMG_1109.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f559d55619af61e2

[melvin-bot]

Current assignee @kevinksullivan is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[MaciejSWM]

Hey! I’m Maciej from Software Mansion, an expert agency, and I’d like to investigate this issue.

Anyone managed to reproduce this? I tested on staging, on iOS+Safari, Android+Chrome, iOS simulator and I can't reproduce the issue. I'm opening the app, scrolling, going to workspaces - bottom button looks well placed for all my devices.

[s77rt]

@MaciejSWM I can't reproduce either. Maybe this is only reproducible if the deeplink banner is shown?

[melvin-bot]

@s77rt @kevinksullivan this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[s77rt]

Melvin, this was reopened just yesterday

[kevinksullivan]

Maybe this is only reproducible if the deeplink banner is shown?

@s77rt were you able to reproduce it for this scenario?

[s77rt]

@kevinksullivan I didn't test for that scenario. The banner was not visible in my case, it seems coming from iOS and not the App and only if certain conditions are met(?). I asked in Slack https://expensify.slack.com/archives/C049HHMV9SM/p1688664348845969?thread_ts=1686663005.982659&cid=C049HHMV9SM for more info.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @jscardona12 got assigned: 2023-07-19 16:10:36 Z
• when the PR got merged: 2023-08-09 15:42:11 UTC
• days elapsed: 14

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change position: absolute for position:fixed in getNavigationModalCard #24305

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment
• @jscardona12 requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger / @kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist is done already #20709 (comment)

[kevinksullivan]

@s77rt do you get paid in NewDot?

[s77rt]

@kevinksullivan No, still in Upwork

[sakluger]

@kevinksullivan are you back and able to handle this one? Or would you like me to handle it?

@jscardona12 regarding your comment on payment, can you clarify where there was a $2000 bounty? This issue shows $1000 so I'm not sure what you're referring to.

[kevinksullivan]

I can do it @sakluger . Still waiting on @jscardona12 's response though.

[jscardona12]

Hi, what I was saying was in a point the regression bounty was 2000 dollars.
Not the original ones. I was wondering if since we reapply a previous fix, that ended up in regression and to be honest the ton of testing and research to find a viable solution if it would be possible to pay 1000.

Thx!

Cc: @kevinksullivan

[sakluger]

I don't see anywhere that the bounty was $2000 - we pay out for this issue based on the price of this issue. We appreciate all your work on this, and testing and research is expected to be included in the job price.

[sakluger]

@kevinksullivan I'm going to remove my assignment now, let me know if you need my help with anything else here!

[kevinksullivan]

following up on process here

https://expensify.slack.com/archives/C01SKUP7QR0/p1692917829830819

[kevinksullivan]

Payments made for $500 due to merge delay.