[$1000] Web - Send money - Replies are not displayed on send money message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app and login with user A
2. Open the app in another device and login with user B
3. From user B, request money to user A
4. Observe in user A, request money message of user B has 'Replies' and its count displayed
5. From user A, send money to user B
6. From user A, click on send money message, send new message and it and again observe that send money message does not have 'Replies' displayed

Expected Result:

App should displays 'Replies' on send money messages too as it does on request money messages

Actual Result:

App does not display 'Replies' on send money messages.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

no.replies.send.money.mp4

Recording.2955.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685207535140439

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019ad41131bcfa9808
• Upwork Job ID: 1666298796414373888
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sophiepintoraetz]

Came in before the long weekend - will catch up on this tomorrow.

[sophiepintoraetz]

I believe I've been able to reproduce this - I get a notification for the reply, as well as it appearing in the LHN but it does not appear in the sent money request.

RPReplay_Final1686111362.MP4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019ad41131bcfa9808

[melvin-bot]

Current assignee @sophiepintoraetz is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @yuwenmemon (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[sophiepintoraetz]

Waiting for some proposals! As a heads up - I will be OOO for a week from next Tuesday, so will reassign the Bug label for a co-conspirator. If we have no proposals in the next few days, let's hand over to the external agencies for some eyes!

[AmjedNazzal]

This seem to be a backend issue, when the api request has a command of "RequestMoney" the response contains childVisibleActionCount which is used to show replies, but when the command is "SendMoneyElsewhere" the response does not contain that.

[sophiepintoraetz]

@yuwenmemon - can you confirm @AmjedNazzal's backend theory? If so, then this needs to be an internal issue, right?

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sophiepintoraetz]

@michaelhaxhiu - thank you 🙏 I'm headed OOO until 20 June, we're just waiting on Yuwen to confirm whether this issue is going to be internal or not. If it is, likely the only payment needed is for the reporter (upwork job is still open).

[yuwenmemon]

Looks to be the case that this is internal.. Thanks @AmjedNazzal!

[melvin-bot]

Current assignee @eVoloshchak is eligible for the Internal assigner, not assigning anyone new.

[michaelhaxhiu]

Just affirmed it's internal, let's give yuwen a few days to get into this.

[melvin-bot]

@yuwenmemon @eVoloshchak @michaelhaxhiu @sophiepintoraetz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[eVoloshchak]

This is an internal issue, Melv, not overdue

[sophiepintoraetz]

@yuwenmemon - when are you able to take a look into this? (thanks Hax for babysitting!)

[yuwenmemon]

It's on my to-do list for today!

[melvin-bot]

@yuwenmemon @eVoloshchak @sophiepintoraetz this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[sophiepintoraetz]

@yuwenmemon - I think this is on you here - let me know if there's something else I can take off your plate so you can get to this?

[yuwenmemon]

Okay @luacmartins or @cristipaval I'm not sure how to best proceed here but after digging in a bit it seems like we're not sending a reportPreviewReportActionID with our sendMoney API calls - is that on purpose?

App/src/libs/actions/IOU.js

Lines 1074 to 1082 in 217059f

	params: {
	iouReportID: optimisticIOUReport.reportID,
	chatReportID: chatReport.reportID,
	reportActionID: optimisticIOUReportAction.reportActionID,
	paymentMethodType,
	transactionID: optimisticTransaction.transactionID,
	newIOUReportDetails,
	createdReportActionID: isNewChat ? optimisticCreatedAction.reportActionID : 0,
	},

Should we be sending that, similar to what we do for RequestMoney and SplitBill?

[cristipaval]

Hey @yuwenmemon! This is because report previews are not optimistically created for send/pay flows. This is the GH issue for it, I'm making this PR ready soon and it will fix this issue.

FYI: I think we're not accepting the bug reports related to sending money anyway. See this Slack announcement.

[yuwenmemon]

Cool! Will close this in favor of that issue then. Thanks @cristipaval!