[HOLD for payment 2024-07-24] Chat - Mentions popup doesn't appear when editing message

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to NewDot
2. Open any chat
3. Send a message
4. Edit message. While editing try to mention any account using @

Expected Result:

Popup should appear with possible mentions

Actual Result:

Popup doesn't appear when editing message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.18.1

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/e5a721eda7a8d29c80c1f999e9737f19fd8a4ae7358fcf6bb3f3630dd717b4b0

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d781c638f8bf0faa
• Upwork Job ID: 1664725947469553664
• Last Price Increase: 2023-06-02

Issue Owner

Current Issue Owner: @Christinadobrzyn / @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

Looks like this is a new feature not a bug

[Christinadobrzyn]

I agree @dukenv0307, looks like a new feature not a bug but I think it's good to push forward.

Can we combine this issue with this fix? #19673

Hey @MariaHCD do you think this is good to build? I think this can be external but let me know if you think it should be internal!

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MariaHCD]

Hey @MariaHCD do you think this is good to build? I think this can be external but let me know if you think it should be internal!

I think it makes sense to have this feature but I think the plan for editing messages with mentions is still a WIP. Could you confirm, @puneetlath?

[puneetlath]

Ah interesting. It looks like neither emoji auto-suggestion or mentions auto-suggestion currently works while editing a comment. I agree it is something we should add though.

@stitesExpensify do you know if we have thought about this for emojis at all already?

[stitesExpensify]

I think this is pretty much as far as we got with it #14686 (comment)

Basically "Yeah, we should add that". I don't think that the discussion continued though

[puneetlath]

I think we should probably wait until we have the inline auto-suggester: #16078

[MariaHCD]

Nice, makes sense. Thanks, @puneetlath! Should this be on hold for the inline auto-suggester? Additionally, I'm assuming once that is complete, this issue can be external?

[puneetlath]

Yes, I think it makes sense to put it on hold for that. After that, yes, I think we could make it external. Though given that it's a new feature and potentially a little complex, it might be a good one for an expert agency to work on.

[Christinadobrzyn]

Not overdue - Added daily label since payment on PR #16078 is tomorrow

[Christinadobrzyn]

Looks like PR is in production so I think we can move forward with this? Adding external.

[perunt]

hey @Christinadobrzyn, the PR is ready and waiting for a review

[Christinadobrzyn]

PR #44720 under review!

[rayane-djouah]

I took over the review since @Santhosh-Sellavel is OOO

[rayane-djouah]

@Christinadobrzyn Please assign me here. Thank you!

[jasperhuangg]

FYI #45435 was missed during testing, I'll have another contributor handle it

[Christinadobrzyn]

PR in Staging - #44720

Getting close!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Suggestion box for edit input #44720

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @perunt does not require payment (Contractor)
• @rayane-djouah requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
• [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rayane-djouah] Determine if we should create a regression test for this bug.
• [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/415160

[Christinadobrzyn]

Preparing for payment

Payouts due:

• Contributor+: $250 @rayane-djouah - (upwork offer - https://www.upwork.com/nx/wm/offer/103238719)

@rayane-djouah do we need a regression test for this?

[rayane-djouah]

Regression Test Proposal

• Testing Emoji Suggestions when editing a message:

1. Open a report.
2. Send a multiline message.
3. Right click on that message and choose Edit message
4. Type an emoji trigger, starting with :sm followed by at least two more characters (e.g., :smile).
5. Verify that the suggestion box appears adjacent to the cursor.
6. Move the cursor to a new position in the text field.
7. Again, type an emoji-like text with at least two characters following the :sm prefix.
8. Confirm that the suggestion box appears next to the cursor as expected.

• Testing Mention Suggestions when editing a message:

1. Open a report.
2. Send a multiline message.
3. Right-click on that message and choose Edit Message
4. Initiate a mention by typing the @ symbol followed by any text (e.g., @username).
5. Verify that the suggestion box appears adjacent to the cursor.
6. Move the cursor to a new position in the text field.
7. Again, Initiate a mention by typing the @ symbol followed by any text (e.g., @username).
8. Confirm that the suggestion box appears next to the cursor as expected.

• Testing scroll disabling when the suggestion box is open when editing a message:

1. Send multiple messages in a report.
2. Edit a message in the middle
3. Type an emoji/mention trigger, starting with :sm (or @ for mention) followed by at least two more characters (e.g., :smile).
4. Scroll over the chat with the suggestion box opened
5. Verify that scrolling is disabled when the suggestion box is opened
6. On desktop, Verify that the cursor type is default outside the suggestion box and hand cursor inside the suggestion box
7. Click on the area outside the box and verify that the suggestion box is closed
8. Verify that scrolling over the chat is enabled now

Do we agree 👍 or 👎

[rayane-djouah]

@rayane-djouah - are you paid in Upwork?

@Christinadobrzyn - Yes I'm being paid in Upwork, I didn't get an offer for this.

[Christinadobrzyn]

Ah thanks @rayane-djouah! Let me create an offer in Upwork... here you go - https://www.upwork.com/nx/wm/offer/103238719

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @perunt is from an agency-contributor and not due payment
• ROLE: @rayane-djouah paid $250 via Upwork

BugZero Checklist (@puneetlath)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1664725947469553664/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Payment day is here - payment summary -#19643 (comment)

Regression test - https://github.com/Expensify/Expensify/issues/415160

closing as complete!