Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: message remains highlighted and does not opens options menu on right click of message #19286

Closed
1 of 6 tasks
kavimuru opened this issue May 19, 2023 · 12 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Needs Reproduction Reproducible steps needed

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to any chat
  2. right click on message

Expected Result :

should open modal which shows different options

Actual Result :

message remains highlighted

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.16.3 DEV
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-19.at.10.31.26.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684475847542959

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels May 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label May 19, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 19, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 19, 2023

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@s77rt
Copy link
Contributor

s77rt commented May 19, 2023

This is fixed already.
#17477 (comment)

@luacmartins
Copy link
Contributor

Gonna CP #19244 to staging, since it fixes this blocker.

@0xmiros
Copy link
Contributor

0xmiros commented May 19, 2023

@luacmartins No need CP please. Original PR isn't deployed to staging yet.
Not sure why deploy blocker label added here

@luacmartins
Copy link
Contributor

luacmartins commented May 19, 2023

Ah thanks for letting me know. Gonna remove the label and close the issue.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label May 19, 2023
@gadhiyamanan
Copy link
Contributor

Am i eligible for reporting bonus as it is reported first in slack ?
Cc: @luacmartins

@luacmartins
Copy link
Contributor

@gadhiyamanan it seems like our team had noticed this issue here

@gadhiyamanan
Copy link
Contributor

gadhiyamanan commented May 19, 2023

i think it was first reported in slack
@luacmartins
Screenshot 2023-05-19 at 7 32 19 PM

Screenshot 2023-05-19 at 7 32 51 PM

@0xmiros
Copy link
Contributor

0xmiros commented May 19, 2023

I first discovered here while reviewing another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Hourly KSv2 Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

8 participants