[HOLD for payment 2023-06-01] [$1000] Loading screen appears every time on app open even if user is not logged in

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. sign out if you are already signin
2. Remove the app from background
3. Reopen the app

Expected Result:

should not show loading screen if user is not logged in

Actual Result:

loading screen appears every time even if user is not logged in

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.8-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

az_recorder_20230428_170411.1.mp4

Screen_Recording_20230428_230519_New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682703466457829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0184a1af5983832ede
• Upwork Job ID: 1653769026183921664
• Last Price Increase: 2023-05-03

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

Reproduced on Android. Adding to Upwork

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0184a1af5983832ede

[MelvinBot]

Current assignee @laurenreidexpensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[laurenreidexpensify]

Totally thuoght I put label on yesterday 🤦‍♀️

[MelvinBot]

Triggered auto assignment to @tylerkaraszewski (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[alitoshmatov]

I think it is expected behavior since regardless of logged in state, and caused by:

App/src/libs/Navigation/NavigationRoot.js

Lines 55 to 59 in e0772ac

	fallback={(
	<FullScreenLoadingIndicator
	style={styles.navigatorFullScreenLoading}
	/>
	)}

[MelvinBot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[0xmiros]

This will be fixed in #17477

[laurenreidexpensify]

@0xmiroslav so are you advising to close?

[fedirjh]

@laurenreidexpensify Let’s hold it until the PR is merged

[roryabraham]

Looks like we think this is going to be fixed by a PR from @zoontek, so I'm assigning this to him to remove the Help Wanted label and to line him up for compensation.

[zoontek]

This is indeed fixed in #17477.

It was caused by the fallback prop on NavigationContainer. In their documentation:

[melvin-bot]

📣 @zoontek You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[gadhiyamanan]

@laurenreidexpensify accepted, thanks!

[fedirjh]

@laurenreidexpensify I am not eligible for compensation here as it was fixed by other PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[0xmiros]

Not blocker anymore, Melvin! It was fixed earlier.

[melvin-bot]

@tylerkaraszewski, @zoontek, @fedirjh, @laurenreidexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

PR has been merged , hasn’t hit staging yet.

[laurenreidexpensify]

On Staging now #17477 (comment)

[0xmiros]

I am also eligible for C+ compensation for reviewing PR

[fedirjh]

@laurenreidexpensify can you please assign the issue to @0xmiroslav as he reviewed the related PR.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.17-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Animate splash screen #17477

If no regressions arise, payment will be issued on 2023-06-01. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

📣 @0xmiroslav You have been assigned to this job by @laurenreidexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[laurenreidexpensify]

@zoontek @gadhiyamanan have been paid in Upwork.

Sorry @0xmiroslav missed the message to add you to the issue - have sent proposal in Upwork, can you complete the checklist above? Thanks

[0xmiros]

No PR caused regression.
This is more like polish and feature request than bug if we never discussed app launch behavior before.

Regression Test Proposal

1. Install the app and open
2. Verify that splash logo shows and then go to login page directly without showing loading indicator
3. Login any account
4. Close the app and reopen
5. Verify that splash logo shows and then go to main page directly without showing loading indicator

[laurenreidexpensify]

Perfect - Regression test requested https://github.com/Expensify/Expensify/issues/288069

[laurenreidexpensify]

Also - payment has been issued in Upwork now!