[HOLD for payment 2023-07-10] Hide threads from LHN if they don't have a comment yet

[grgia]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01aee66cc771604fe5
• Upwork Job ID: 1659267104086478848
• Last Price Increase: 2023-05-18

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01aee66cc771604fe5

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[grgia]

@chiragsalian some thoughts-

we can 1) simply filter out reports that have no visible actions on the parentReportAction aka this branch: https://github.com/Expensify/App/pull/new/georgia-hideEmptyThreads

or 2) we don't start adding users to the participants list until at least one comment has been made

[chiragsalian]

i would suggest 1, because if we go with 2 then that's changing the participant list data to work drastically different for threads. Plus with solution 2, then once the user is in the chat and they click members they won't see themselves which is incorrect.
So option 1 sounds correct to me.

[grgia]

draft PR up, but need to fix the optimistic data

[grgia]

still in progress

[grgia]

I need to update my PR to fix the optimistic data

[melvin-bot]

@mollfpr, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

still need to update

[JmillsExpensify]

Isn't this a duplicate of this older issue?

[PauloGasparSv]

Isn't this a duplicate of this #14523?

Hey @JmillsExpensify since this issue is specific to Threads I don't think it is a duplicate! I checked the draft P.R. logic and compared it with the one you mentioned and since I'm adding another clause and param to shouldReportBeInOptionList I don't think we have any conflicts in logic either : )

[melvin-bot]

@mollfpr, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

Still need to update unit tests

[grgia]

Working on the jest tests question brought up here - https://expensify.slack.com/archives/C04878MDF34/p1686218695956109

[melvin-bot]

@mollfpr, @grgia Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@mollfpr, @grgia Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[grgia]

@MitchExpensify added BZ label to help with C+ $1000 PR Review Payment for this PR - #19375

[MitchExpensify]

Upwork job created for C+ payment and hire offer sent to @mollfpr https://www.upwork.com/jobs/~01393c0b271fdfe3bc

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.35-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide Threads with No Comments from LHN  #19375

If no regressions arise, payment will be issued on 2023-07-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Added a reminder to pay on the 10th. Friendly reminder to take a look at the BZ checklist above @mollfpr 👍

[Julesssss]

Hey, just curious how this should work for tasks? Currently uncommented tasks disappear which doesn't seem expected

[Li357]

Asked here https://expensify.slack.com/archives/C03TQ48KC/p1688651948215299 seems like only chat threads should disappear?

[MitchExpensify]

Paid and contract ended! @mollfpr

[MitchExpensify]

Are their any tests we should add for this change? #19205 (comment)

[mollfpr]

We need the regression step here.

Web/Desktop/Large screen

1. Create a thread from a message
2. Verify that the thread report appears in the LHN
3. Begin Typing a message; note that the thread still appears in LHN with the edit icon.
4. Click another report
5. Verify that the threaded message with no replies no longer appears in the LHN
6. Create a thread from a message, and comment
7. Click another report
8. Verify that the threaded message with no replies remains in the LHN

mWeb/Mobile/Small screen

1. Create a thread, don't comment
2. Go back to LHN/chat list page
3. Verify that the newly created thread does not appear

[MitchExpensify]

Issue to add new test here