Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-05-23] Updating the report header for thread reports #18755

Closed
chiragsalian opened this issue May 10, 2023 · 15 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@chiragsalian
Copy link
Contributor

chiragsalian commented May 10, 2023

https://docs.google.com/document/d/18uQqP0eTe1kWPrQiQwjv_A6u3cBO3VtiwA55XndjCnY/edit#bookmark=id.rozkmqxmc7gb

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ebf41ba655824e9b
  • Upwork Job ID: 1656454552644759552
  • Last Price Increase: 2023-05-11
@chiragsalian chiragsalian added Daily KSv2 Engineering NewFeature Something to build that is a new item. labels May 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 10, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 10, 2023
@chiragsalian chiragsalian added Reviewing Has a PR in review Daily KSv2 and removed Weekly KSv2 labels May 10, 2023
@chiragsalian chiragsalian added the Internal Requires API changes or must be handled by Expensify staff label May 11, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01ebf41ba655824e9b

@melvin-bot
Copy link

melvin-bot bot commented May 11, 2023

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels May 16, 2023
@melvin-bot melvin-bot bot changed the title Updating the report header for thread reports [HOLD for payment 2023-05-23] Updating the report header for thread reports May 16, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-05-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot
Copy link

melvin-bot bot commented May 17, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@sophiepintoraetz
Copy link
Contributor

sophiepintoraetz commented May 22, 2023

@grgia @stitesExpensify or @chiragsalian, is it just @s77rt that's awaiting payment? If so, how much?

@sophiepintoraetz sophiepintoraetz removed their assignment May 22, 2023
@sophiepintoraetz sophiepintoraetz added NewFeature Something to build that is a new item. and removed NewFeature Something to build that is a new item. labels May 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 22, 2023

@sophiepintoraetz
Copy link
Contributor

@sonialiap - I think this is just waiting on confirmation for the payment amount that's due tomorrow (I'm headed OOO today for the week!). Job is here.

@sophiepintoraetz sophiepintoraetz self-assigned this May 22, 2023
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels May 23, 2023
@sonialiap
Copy link
Contributor

sonialiap commented May 25, 2023

@grgia @stitesExpensify or @chiragsalian, bumping Sophie's question

is it just @s77rt that's awaiting payment? If so, how much? The base $1,000?

@melvin-bot melvin-bot bot removed the Overdue label May 25, 2023
@grgia
Copy link
Contributor

grgia commented May 26, 2023

$1000 for internal C+ review @sonialiap

@s77rt
Copy link
Contributor

s77rt commented May 26, 2023

I think it's $500 for this regression #19490 (#18522 (comment)).

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@sonialiap
Copy link
Contributor

Thanks!

@s77rt offer sent

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@s77rt
Copy link
Contributor

s77rt commented May 29, 2023

Accepted!

@sonialiap
Copy link
Contributor

Paid 💸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

6 participants