[HOLD for payment 2023-05-29] in workspace chat, workspace details are missing in header

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Action Performed:
2. go to Settings > Workspaces
3. create new workspace
4. close the modal
5. click on workspace chat in LHN
6. check the header

Expected Result:

should show workspace name in header

Actual Result:

details are missing in header

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.14.4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-16.at.12.58.21.PM.mov

Recording.633.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684222206427449

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

Not able to reproduce this in staging not production

Staging:

Screen.Recording.2023-05-17.at.9.19.28.AM.mov

Production:

Screen.Recording.2023-05-17.at.9.20.49.AM.mov

[hungvu193]

@luacmartins I can reproduce this on latest main

[hungvu193]

@luacmartins The problem came from this line in headerview:

    const reportHeaderData = (isTaskReport || !isThread) && !_.isEmpty(props.parentReport) ? props.parentReport : props.report;

it should be:

(isTaskReport || !isThread ) && !_.isEmpty(props.parentReport) && !isPolicyExpenseChat ? props.parentReport : props.report;

[hungvu193]

Proposal

Please re-state the problem that we are trying to solve in this issue.

in workspace chat, workspace details are missing in header

What is the root cause of that problem?

The problem came from this line:

App/src/pages/home/HeaderView.js

Line 79 in 3bee6f9

const reportHeaderData = (isTaskReport || !isThread) && !_.isEmpty(props.parentReport) ? props.parentReport : props.report;

Let take a look at the prop of workspace, I posted above. The parentReport isn't empty, so this condition return true and reportHeaderData will be props.parentReport which is an object of report key, because of that ReportUtils.getReportName(reportHeaderData); will return empty since getPolicyExpenseChatName couldn't get information from it.

What changes do you think we should make in order to solve the problem?

The condition here should be:

const reportHeaderData = (isTaskReport || !isThread) && !_.isEmpty(props.parentReport) && !isPolicyExpenseChat ? props.parentReport : props.report;props.report;

We should check the condition if this is Policy Expense Chat then we should use props.report instead of props.parentReport

What alternative solutions did you explore? (Optional)

None

[luacmartins]

I could reproduce and this is indeed a blocker

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

in workspace chat and new chat, header are missing

What is the root cause of that problem?

This PR caused this bug
in here

App/src/pages/home/HeaderView.js

Line 79 in 3559764

const reportHeaderData = (isTaskReport || !isThread) && !_.isEmpty(props.parentReport) ? props.parentReport : props.report;

We are having the wrong condition (isTaskReport || !isThread)

What changes do you think we should make in order to solve the problem?

We should update reportHeaderData like this

    const reportHeaderData = isTaskReport && !_.isEmpty(props.parentReport) ? props.parentReport : props.report;

What alternative solutions did you explore? (Optional)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.15-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fallback on report #19127

If no regressions arise, payment will be issued on 2023-05-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[chiragsalian]

PR was CP-d and its on production too so this is not a deploy blocker. Removing label.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.16-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fallback on report #19127

If no regressions arise, payment will be issued on 2023-05-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR: Update task detailed view  #18676
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Update task detailed view  #18676 (comment)
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@luacmartins] Determine if we should create a regression test for this bug. No need, this would be pretty obvious to spot during regression tests.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

@mallenexpensify checklist complete. We just need to process payment now.

[luacmartins]

Lol why are there 2 payment dates here? I think it should be the 2nd one since the fix was deployed to prod 4 days ago. Please correct me if I'm wrong

[gadhiyamanan]

I think it's on production 9 days ago as per #19127 (comment)
cc :@luacmartins @mallenexpensify

[luacmartins]

@gadhiyamanan thanks! In Any case, payment is due today.

[mallenexpensify]

@gadhiyamanan can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b912fd94ec4da0e0

Only payment due is the reporting bonus, right? Comment if not!

[gadhiyamanan]

@mallenexpensify accepted, thanks!

[mallenexpensify]

@gadhiyamanan paid! Closing