[HOLD for payment][$1000] App displays older message in LHN if we send message directly after editing previous message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open any report
3. Send any message
4. Type in any message and edit previously send message
5. Send enter twice to first save the edited message and then send the currently written message in compose box
6. Observe in LHN that previous edited message is displayed and not the new message

Expected Result:

App should always display latest sent message in LHN

Actual Result:

App displays previous edited message if we send message directly after editing previous message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.7.2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

LHN.not.updated.with.new.message.mp4

Recording.394.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682587455957279

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0189fd1082d549e699
• Upwork Job ID: 1655690523839213568
• Last Price Increase: 2023-05-08

[MelvinBot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@adelekennedy Huh... This is 4 days overdue. Who can take care of this?

[adelekennedy]

I am not able to reproduce, when I follow the steps above the most recent message shows in the LHN for me, not the edited version

[adelekennedy]

I followed the steps above on staging but my most recent message still appears in the LHN (not most recently edited)

[dhanashree-sawant]

Hi @adelekennedy , I tried on latest build and was able to reproduce. Key here is send any message, write some text in compose box, edit the last written message (do not save it) and press enter twice to first save the edit message and then send new written message.

[melvin-bot]

@adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[adelekennedy]

it still doesn't reproduce for me, but if you're still able to then let's move forward

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0189fd1082d549e699

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

Triggered auto assignment to @MariaHCD (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[tienifr]

IMO this is an example of the 'replay effect' which is mentioned and should be resolved in this issue. In short, we are performing consecutive write operations for a same Onyx key report_{id} in a short amount of time.

In this case, the order of the Onyx update operation received from Pusher is messed up due to the SequentialQueue implementation. I think it would be resolved after the above tracking issue is completed.

Should be on hold I guess?

[MariaHCD]

Thanks, @tienifr! I agree that this is related to the replay effect issue. We can revisit & retest this once the PR fixes are deployed as part of that tracking issue.

[MariaHCD]

As an additional note, I was able to reproduce the issue on dev:

Screen.Recording.2023-05-09.at.6.15.42.PM.mov

[MariaHCD]

Just noticed, if you delete a comment and then add a new comment while DeleteComment hasn't finished yet, the last message in the LHN also reverts back to the previous message:

Screen.Recording.2023-05-23.at.6.11.10.PM.mov

[MariaHCD]

Tested with adding an attachment and then sending a message right after, it results in the same behavior, as soon as AddComment completes, the last message in the LHN is reverted to the previous message instead of the latest one.

Screen.Recording.2023-05-23.at.6.13.56.PM.mov

[MariaHCD]

Let's have the external community continue the investigation in the other issue. I'll keep an eye out and see if we should just close this one out (after paying the bug reporter) and update that issue to include this scenario.

[melvin-bot]

@MariaHCD @sonialiap @adelekennedy @0xmiroslav this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

[sonialiap]

@MariaHCD should we add hold to the title of this issue?

[MariaHCD]

@sonialiap Done! Currently on hold for #12775

[MariaHCD]

It still looks like we're on hold here.

[sonialiap]

Still on hold for #12775

[neil-marcellini]

#12775 is off hold, but based on Maria's comment #18102 (comment) we might want to hold on #16530.

[MariaHCD]

Looks like #16530 is no longer reproducible 🙏🏼 #16530 (comment)

@kavimuru can we retest this and verify if the issue still exists?

[MariaHCD]

We just need to verify if this is still reproducible. Bump @kavimuru :)

[kavimuru]

@MariaHCD I am seeing different issue now. When I hit Enter couple times, message from the composer does not get posted.

Recording.1115.mp4

[MariaHCD]

When I hit Enter couple times, message from the composer does not get posted.

In the video, it looks like the composer is no longer focused after editing the previous message. It doesn't seem related to this issue, though. So maybe it's worth opening up a new issue (if one does not already exist).

I retested it on Chrome (Mac) and the message in the LHN correctly shows the latest message 🎊

Screen.Recording.2023-06-28.at.12.12.13.PM.mov

Let's pay the bug reporter and close this out! cc: @sonialiap

[sonialiap]

@dhanashree-sawant offer sent for reporting issue

Upwork link

I'll be OOO tomorrow and Monday, I'll check tomorrow morning in case the offer is accepted, but if it isn't before I head out then I'll complete payment as soon as I'm back online!

[sonialiap]

Back from OOO, paid ✅