[HOLD for payment 2023-05-16] Personal Details - In city name only the first letter stays capital after saving the address

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Navigate to settings > profile
2. Go to Personal details > Home address
3. In City field use N.Y.C

Expected Result:

The city name shouldn't change

Actual Result:

Only the first letter stays capital

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.1.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-18.at.11.06.23.PM.mov

Expensify/Expensify Issue URL:

Issue reported by: @thesahindia

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681841912744349

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010b96191c22f1f471
• Upwork Job ID: 1648833642620362752
• Last Price Increase: 2023-04-19

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

This will need to be internal, since we have to update the backend. Basically following the exact same pattern as #16960 for whoever gets this!

[NicMendonca]

Oh wow, I don't think many new yorkers would type N.Y.C 😅

This is only happening when there are periods between the letters:

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~010b96191c22f1f471

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[MelvinBot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

oh hey, this makes it easy. I'll essentially do the same thing I did on that other PR.

[dangrous]

Waiting for deploy on this one still

[dangrous]

Still waiting for deploy to prod (on staging now at least); App PR is already reviewed though so it'll be quick once everything's up.

[dangrous]

App PR is merged, on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Send homeAddressCity parameter to prevent autoformatting #17719

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR: N/A - see [HOLD for payment 2023-05-16] Personal Details - In city name only the first letter stays capital after saving the address #17666 (comment)
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A - see [HOLD for payment 2023-05-16] Personal Details - In city name only the first letter stays capital after saving the address #17666 (comment)
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - see [HOLD for payment 2023-05-16] Personal Details - In city name only the first letter stays capital after saving the address #17666 (comment)
• [@mollfpr] Determine if we should create a regression test for this bug. NO
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

As with #16960, this wasn't really a bug - just an edge case that wasn't thought about. The PR was literally the creation of the file on the backend in 2012 (they used a different method to do the capitalization, but it was there from the beginning). I don't think commenting will be helpful, nor will a discussion or a regression test. Let me know if you disagree @mollfpr, but I'll check off the list for now.

[mollfpr]

Thanks @dangrous for taking care the checklist.

I also agree with you 👍

[NicMendonca]

@mollfpr @thesahindia please apply to the job so I can issue payment: https://www.upwork.com/jobs/~010b96191c22f1f471

[mollfpr]

@NicMendonca Applied!

[thesahindia]

Applied, thanks!

[NicMendonca]

@mollfpr @thesahindia sent the offer!

[mollfpr]

@NicMendonca accepted, thank you!

[thesahindia]

I have accepted the offer as well!

[NicMendonca]

Both paid! Thank you!