[HOLD for payment 2023-07-05] [$1000] Pressing and holding back key in a phone number field resets country selection

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Click on “Profile” avatar
2. Click on “Workspace” link
3. Click on “Issue cards” link
4. Click on “Connect manually” link
5. Fill out all forms and submit the forms leading to “Personal Information” form
6. Enter personal information and click on “save & continue” button
7. Click on “Passport” button
8. Click on “Get secure link” button
9. Click on “Get link via SMS” link
10. Select a country using dropdown menu
11. Enter number
12. Press and hold back key

Expected Result:

Country selection should not reset

Actual Result:

Country selection resets to the default value

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.91-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-03-28.14.44.40.mp4

Recording.79.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680004375167929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016fa3b4a81adeeec1
• Upwork Job ID: 1643650089223389184
• Last Price Increase: 2023-04-19

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@michaelhaxhiu Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

@michaelhaxhiu Still overdue 6 days?! Let's take care of this!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~016fa3b4a81adeeec1

[michaelhaxhiu]

This is a valid bug report, let's fix it

[MelvinBot]

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[MelvinBot]

Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[daraksha-dk]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing and holding back key in a phone number field resets country selection

What is the root cause of that problem?

This also happens when the user tries to enter the 18th digit in the field. This is a UX issue at Onfido's end.

What changes do you think we should make in order to solve the problem?

As the issue is at their end, I think it should be handled there only - I've raised the issue

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While trying to add a bank account using the manual option, the user gets to a point where they have to enter their phone number in order to obtain a secure link. After selecting the country and entering a phone number, if the holder holds the Backspace key to delete the entry, the keyboard input eventually causes the option in the select box to reset.

What is the root cause of that problem?

This is occurring with dynamically injected code from the onfido-sdk-ui dependency.

What changes do you think we should make in order to solve the problem?

It may be possible to create a dynamic JavaScript event to intercept the keypress event for the Backspace button and cancel the default event behaviour for the select HTML element with the class name PhoneInputCountrySelect. The dynamic code is accessible in the DOM, as it's not an placed within an iframe. However, if onfido changes the dynamically generated code in the future, this will cause a regression.

What alternative solutions did you explore?

Possibly filing an issue with the onfido-sdk-ui team to fix the problem.

[daraksha-dk]

#14766 (comment)
Based on our past experience, we should also send an email to the dedicated CSM.

[rushatgabhane]

reviewing

[rushatgabhane]

@michaelhaxhiu I think this issue is all yours :) #16640 (comment)

Thanks for raising the issue on onfido's repo 🙌 @daraksha-dk

[MelvinBot]

@michaelhaxhiu, @Gonals, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@michaelhaxhiu, @Gonals, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@michaelhaxhiu @Gonals @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@michaelhaxhiu, @Gonals, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...

[MelvinBot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[daraksha-dk]

PR is ready for review!

cc: @rushatgabhane

[melvin-bot]

🎯 ⚡️ Woah @rushatgabhane / @daraksha-dk, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @daraksha-dk got assigned: 2023-06-21 17:34:05 Z
• when the PR got merged: 2023-06-26 10:10:20 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.33-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• upgrade onfido-sdk-ui to fix 16640 #21236

If no regressions arise, payment will be issued on 2023-07-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@michaelhaxhiu] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[rushatgabhane]

1. The PR that introduced the bug has been identified. Link to the PR: N.A. because bug existed in third party library onfido-sdk-ui

2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N.A. because bug existed in third party library onfido-sdk-ui

3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A. because bug existed in third party library onfido-sdk-ui

4. Determine if we should create a regression test for this bug. No

5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N.A.

[rushatgabhane]

Rushat is paid on new dot - https://staging.new.expensify.com/r/2544257188075288

[melvin-bot]

@MariaHCD, @michaelhaxhiu, @rushatgabhane, @daraksha-dk Eep! 4 days overdue now. Issues have feelings too...

[michaelhaxhiu]

Let's get this paid :)

[michaelhaxhiu]

Invited Daraksha & Natnael to the job on upwork. Please comment here when you accept.

• $1500 = Rushat (paid via newdot)
• $1500 = Daraksha
• $250 = Natnael

[Natnael-Guchima]

Accepted the offer. Thanks @michaelhaxhiu

[daraksha-dk]

@michaelhaxhiu I have accepted the offer, thank you!

[michaelhaxhiu]

WTF is wrong with upwork 🖕 The job link is expired as of today 😒

[michaelhaxhiu]

They should rename to BusyWork instead of UpWork. 😠

New job link is here - invited you again because upwork wants us to repeat this step a thousand times.
https://www.upwork.com/jobs/~01d6ed8d5f098694bb

[Natnael-Guchima]

I have accepted the offer. Thanks @michaelhaxhiu

[daraksha-dk]

Accepted the offer. Thanks @michaelhaxhiu

[michaelhaxhiu]

all paid