Failed workflow comments in slack do not have the correct URL

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Have a failed GitHub Actions workflow ping in Slack.
2. Click on the link to the failed workflow.

Expected Result:

You should be taken to the failed workflow.

Actual Result:

You are taken to the GitHub Actions dashboard and have to look for the failed workflow manually.

Workaround:

n/a

Platform:

GitHub Actions

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[roryabraham]

Since this is internal, I'm going to remove @conorpendergrast as an assignee.

[roryabraham]

Screw you melvin, this should be a weekly, at best.

[mallenexpensify]

@roryabraham , we're wanting BZ assigned for internal bugs and for them to remain daily, does the OP have everything needed to be worked on? Also.. I'm double checking here on the exact process here for engineers and bug issues

[melvin-bot]

@conorpendergrast, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[conorpendergrast]

@roryabraham bump on Matt's questions above! #12392 (comment)

[conorpendergrast]

@roryabraham Second bump!

[roryabraham]

The OP does indeed have everything it needs to be worked on imo

[conorpendergrast]

Ok, great! So now we just... leave ourselves assigned, and this set to Daily, until.. what?

[roryabraham]

Created a PR against the upstream actions/slack repo to add a feature to make this more convenient: 8398a7/action-slack#230

[roryabraham]

Also so we don't have to wait around with this issue open, I created a workaround that should fix this in our repo: #12873. That way we don't have to deal with a fork or wait for the maintainer to review + release my new feature in the upstream. I will get notified if my PR is merged and then I can pretty easily do a follow-up to use the upstream feature, if we even want to. The fix in our repo might be fine

[roryabraham]

So now we just... leave ourselves assigned, and this set to Daily, until.. what?

Sass noted btw, @conorpendergrast 😆

[conorpendergrast]

Hah, sorry - genuinely not sass, just total confusion Conor Pendergrast Concierge Team, Expensify

…

On Sat, 19 Nov 2022 at 13:47, Rory Abraham ***@***.***> wrote: So now we just... leave ourselves assigned, and this set to Daily, until.. what? Sass noted btw, @conorpendergrast <https://github.com/conorpendergrast> 😆 — Reply to this email directly, view it on GitHub <#12392 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABMIT3P3FOF3INOE57CRKHLWJAPRDANCNFSM6AAAAAARVMKYH4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melvin-bot]

@conorpendergrast, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[roryabraham]

My upstream fix was merged over the weekend. I'll keep this open for now to switch from the workaround to the upstream fix.

[roryabraham]

Final cleanup PR ready for review: #13121

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Link to workflow run using upstream feature #13121

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@roryabraham] The PR that introduced the bug has been identified. Link to the PR: n/a this was an improvement over functionality that has been there since the very early days of NewDot, back when it was still called Expensify/ReactNativeChat (even before it was temporarily called Expensify.cash)
• [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
• [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
• [@conorpendergrast] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: n/a

[roryabraham]

This was all internal, no C+ review. So no payment due