Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #8503] [Tracking] [Performance] Enable React 18 #11680

Closed
2 of 3 tasks
roryabraham opened this issue Oct 7, 2022 · 21 comments
Closed
2 of 3 tasks

[HOLD #8503] [Tracking] [Performance] Enable React 18 #11680

roryabraham opened this issue Oct 7, 2022 · 21 comments
Assignees
Labels
Engineering Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Oct 7, 2022

Problem

React 18 introduces a lot of new features that improve performance. Some of those, such as "Automatic Batching" come out-of-the-box for free, and others such as Suspense, startTransition, and useSyncExternalStore are opt-in.

However, we can't use the opt-in features until React 18 is supported on all platforms.

Solution

Enable React 18 on all platforms. This involves a number of tasks:

@roryabraham roryabraham added Engineering Weekly KSv2 NewFeature Something to build that is a new item. labels Oct 7, 2022
@roryabraham roryabraham self-assigned this Oct 7, 2022
@roryabraham
Copy link
Contributor Author

Branched this issue off from #8503 for a more correct separation of concerns.

@roryabraham
Copy link
Contributor Author

No update for now but there's a milestone here. Going to make this a monthly while we're waiting.

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2022
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Oct 18, 2022
@JmillsExpensify JmillsExpensify changed the title [Performance] Enable React 18 [HOLD] [Performance] Enable React 18 Oct 18, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD] [Performance] Enable React 18 [HOLD #8503] [Performance] Enable React 18 Oct 19, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD #8503] [Performance] Enable React 18 [HOLD #8503] [Tracking] [Performance] Enable React 18 Oct 19, 2022
@sakluger
Copy link
Contributor

Noting that @aneequeahmad reported this bug first, so they are eligible for a reporting bonus. @roryabraham feel free to assign me to the issue when it's just about completed so I can create and link an Upwork job.

@JmillsExpensify
Copy link

@roryabraham Now that we've removed Fabric from WAQ, I'm kind of thinking we should remove React 18 from the initiative as well. Obviously we still need to do this, and related there are performance improvements, but this is still bleeding edge. Do you agree with that?

@melvin-bot melvin-bot bot added the Overdue label Nov 18, 2022
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2022
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Dec 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Jan 23, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Jan 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Feb 27, 2023
@roryabraham
Copy link
Contributor Author

Seems many issues on the milestone have PRs, but so far only one of the issues in the milestone is closed. So it feels like we're still some months away from taking this off HOLD

@melvin-bot melvin-bot bot added the Overdue label Jun 5, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD. We're making faster progress on the Touchables migration so we should be able to remove the HOLD soon

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Jul 31, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 1, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD

@melvin-bot melvin-bot bot removed the Overdue label Sep 1, 2023
@roryabraham
Copy link
Contributor Author

I know @WoLewicki and @j-piasecki were interested in this after we turn on the new arch

@roryabraham
Copy link
Contributor Author

Still on HOLD for new arch and #24482

@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 6, 2023
@roryabraham
Copy link
Contributor Author

Still on HOLD

@roryabraham
Copy link
Contributor Author

Probably the best article I've found on React 18 concurrent features: https://vercel.com/blog/how-react-18-improves-application-performance

@roryabraham
Copy link
Contributor Author

Still on HOLD but we're getting closer and this will be 🔥

@melvin-bot melvin-bot bot removed the Overdue label Dec 20, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 22, 2024
@roryabraham
Copy link
Contributor Author

Still on HOLD, but this came up recently here

@melvin-bot melvin-bot bot removed the Overdue label Jan 22, 2024
@roryabraham
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Monthly KSv2 NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

3 participants