Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] BUG: DEV - Console error on web app load react-dom.development.js?.. - reported by @aneequeahmad #11904

Closed
mvtglobally opened this issue Oct 17, 2022 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Launch web app
  2. See the error in console.

Expected Result:

No Errors should display

Actual Result:

Console error on web app load react-dom.development.js?61bb:86 Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17.

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.12-3
Reproducible in staging?: N
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

bug-dev-react18.mov

Screenshot 2022-09-08 at 8 48 37 AM

Expensify/Expensify Issue URL:
Issue reported by: @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661251204472079

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Needs Reproduction Reproducible steps needed labels Oct 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2022

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member labels Oct 17, 2022
@sakluger sakluger added Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor labels Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 18, 2022
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2022

Triggered auto assignment to @srikarparsi (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title BUG: DEV - Console error on web app load react-dom.development.js?.. - reported by @aneequeahmad [$250] BUG: DEV - Console error on web app load react-dom.development.js?.. - reported by @aneequeahmad Oct 18, 2022
@parasharrajat
Copy link
Member

parasharrajat commented Oct 18, 2022

There is an internal issue #11680 which is going to fix it. Thus this is kind of duplicate. And we have been discussing this #8503 for a long time.

@sakluger
Copy link
Contributor

Thanks @parasharrajat - if this is a duplicate, do you recommend closing this one?

@michaelhaxhiu
Copy link
Contributor

@parasharrajat do you think we ought to pay a reporting bonus for this when the internal issue is resolved? cc @roryabraham since you are assigned to the internal issues.

IMO this doesn't get paid and closed until we decide if (1) it's a tue duplicate or not and (2) the problem is actually fixed.

@parasharrajat
Copy link
Member

parasharrajat commented Oct 18, 2022

So this was reported on Aug 23 and we created an internal issue on #8503 (comment).

Seems like eligible for reporting bonus. I suggest closing this one and updating #11680 if eligible for reporting bonus.

@roryabraham
Copy link
Contributor

Fair's fair – @aneequeahmad beat me to reporting this so I agree with @parasharrajat's last message.

@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@sakluger
Copy link
Contributor

Cool, closing in favor of #11680. I left a comment on that issue that @aneequeahmad should be paid the reporting bonus once it's completed.

@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

6 participants