refactor: remove reportOrDraft variable and pass default value to can…

…UserPerformWriteAction function only
Expensify · Sep 23, 2024 · edf4ee7 · edf4ee7
1 parent f616bab
commit edf4ee7
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/pages/iou/request/step/withWritableReportOrNotFound.tsx b/src/pages/iou/request/step/withWritableReportOrNotFound.tsx
@@ -57,17 +57,15 @@ export default function <TProps extends WithWritableReportOrNotFoundProps<MoneyR
         const [isLoadingApp = true] = useOnyx(ONYXKEYS.IS_LOADING_APP);
         const [reportDraft] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_DRAFT}${route.params.reportID ?? '-1'}`);
 
-        const reportOrDefault = report ?? {reportID: ''};
-
         const iouTypeParamIsInvalid = !Object.values(CONST.IOU.TYPE)
             .filter((type) => shouldIncludeDeprecatedIOUType || (type !== CONST.IOU.TYPE.REQUEST && type !== CONST.IOU.TYPE.SEND))
             .includes(route.params?.iouType);
         const isEditing = 'action' in route.params && route.params?.action === CONST.IOU.ACTION.EDIT;
 
-        const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(reportOrDefault);
+        const canUserPerformWriteAction = ReportUtils.canUserPerformWriteAction(report ?? {reportID: ''});
 
         useEffect(() => {
-            if (!!reportOrDefault?.reportID || !route.params.reportID || !!reportDraft || !isEditing) {
+            if (!!report?.reportID || !route.params.reportID || !!reportDraft || !isEditing) {
                 return;
             }
             ReportActions.openReport(route.params.reportID);