Skip to content

Commit

Permalink
Merge pull request #41830 from bernhardoj/fix/40683-status-bar-color
Browse files Browse the repository at this point in the history
Fix status bar of mWeb Safari doesn't match the splash screen background color
  • Loading branch information
grgia authored Jun 14, 2024
2 parents 1c88c60 + 381c92d commit ebafd6c
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 24 deletions.
5 changes: 0 additions & 5 deletions src/components/CustomStatusBarAndBackground/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,6 @@ function CustomStatusBarAndBackground({isNested = false}: CustomStatusBarAndBack
[prevIsRootStatusBarEnabled, isRootStatusBarEnabled, statusBarAnimation, statusBarStyle, theme.PAGE_THEMES, theme.appBG, theme.statusBarStyle],
);

useEffect(() => {
updateStatusBarAppearance({backgroundColor: theme.appBG});
// eslint-disable-next-line react-hooks/exhaustive-deps -- we only want this to run on first render
}, []);

useEffect(() => {
didForceUpdateStatusBarRef.current = false;
}, [isRootStatusBarEnabled]);
Expand Down
7 changes: 0 additions & 7 deletions src/libs/getSplashBackgroundColor/index.native.ts

This file was deleted.

7 changes: 0 additions & 7 deletions src/libs/getSplashBackgroundColor/index.ts

This file was deleted.

3 changes: 1 addition & 2 deletions src/styles/theme/themes/dark.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import getSplashBackgroundColor from '@libs/getSplashBackgroundColor';
import colors from '@styles/theme/colors';
import type {ThemeColors} from '@styles/theme/types';
import CONST from '@src/CONST';
Expand All @@ -7,7 +6,7 @@ import SCREENS from '@src/SCREENS';
const darkTheme = {
// Figma keys
appBG: colors.productDark100,
splashBG: getSplashBackgroundColor(),
splashBG: colors.green400,
highlightBG: colors.productDark200,
border: colors.productDark400,
borderLighter: colors.productDark400,
Expand Down
3 changes: 1 addition & 2 deletions src/styles/theme/themes/light.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import getSplashBackgroundColor from '@libs/getSplashBackgroundColor';
import colors from '@styles/theme/colors';
import type {ThemeColors} from '@styles/theme/types';
import CONST from '@src/CONST';
Expand All @@ -7,7 +6,7 @@ import SCREENS from '@src/SCREENS';
const lightTheme = {
// Figma keys
appBG: colors.productLight100,
splashBG: getSplashBackgroundColor(),
splashBG: colors.green400,
highlightBG: colors.productLight200,
border: colors.productLight400,
borderLighter: colors.productLight400,
Expand Down
2 changes: 1 addition & 1 deletion web/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<meta charset="utf-8" />
<title>New Expensify</title>
<meta name="description" content="Corporate cards, reimbursements, receipt scanning, invoicing, and bill pay.">
<meta name="theme-color" content="">
<meta name="theme-color" content="#03D47C">
<meta property="twitter:card" content="summary">
<meta property="twitter:site" content="@expensify">
<meta property="og:type" content="website">
Expand Down

0 comments on commit ebafd6c

Please sign in to comment.