Skip to content

Commit

Permalink
Merge pull request #43634 from bernhardoj/fix/43394-emoji-cut-off-aft…
Browse files Browse the repository at this point in the history
…er-edit

Fix emoji with markdown on edit cut off on top
  • Loading branch information
carlosmiceli authored Jun 19, 2024
2 parents e0ff35b + dd494e7 commit c85ebdf
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ function EditedRenderer({tnode, TDefaultRenderer, style, ...defaultRendererProps
const styles = useThemeStyles();
const {translate} = useLocalize();
const isPendingDelete = !!(tnode.attributes.deleted !== undefined);
const isLarge = !!(tnode.attributes.islarge !== undefined);
return (
<Text>
<Text style={isLarge && styles.onlyEmojisTextLineHeight}>
<Text
style={styles.userSelectNone}
fontSize={variables.fontSizeSmall}
dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: true}}
>
{' '}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/report/comment/TextCommentFragment.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function TextCommentFragment({fragment, styleAsDeleted, styleAsMuted = false, so
// on other device, only render it as text if the only difference is <br /> tag
const containsOnlyEmojis = EmojiUtils.containsOnlyEmojis(text ?? '');
if (!shouldRenderAsText(html, text ?? '') && !(containsOnlyEmojis && styleAsDeleted)) {
const editedTag = fragment?.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''}></edited>` : '';
const editedTag = fragment?.isEdited ? `<edited ${styleAsDeleted ? 'deleted' : ''} ${containsOnlyEmojis ? 'islarge' : ''}></edited>` : '';
const htmlWithDeletedTag = styleAsDeleted ? `<del>${html}</del>` : html;

const htmlContent = containsOnlyEmojis ? Str.replaceAll(htmlWithDeletedTag, '<emoji>', '<emoji islarge>') : htmlWithDeletedTag;
Expand Down

0 comments on commit c85ebdf

Please sign in to comment.