Merge pull request #22226 from Expensify/marcaaron-killIOUSend

Temporarily disable the "Send Money" option

docs/_data/_routes.yml

@@ -5,9 +5,9 @@ home:
 
 # Hubs are comprised of sections and articles. Sections contain multiple related articles, but there can be standalone articles as well
 hubs:
-  - href: send-money
-    title: Send money
-    description: With only a couple of clicks, send money to your friends or coworkers.
+  - href: split-bills
+    title: Split bills
+    description: With only a couple of clicks, split bills with your friends or coworkers.
     icon: /assets/images/paper-airplane.svg
 
   - href: request-money

docs/articles/request-money/Request-and-Split-Bills.md

@@ -0,0 +1,35 @@
+---
+title: Request Money and Split Bills with Friends
+description: Everything you need to know about Requesting Money and Splitting Bills with Friends!
+---
+
+<!-- The lines above are required by Jekyll to process the .md file -->
+
+# How do these Payment Features work?
+Our suite of money movement features enables you to request money owed by an individual or split a bill with a group.
+
+**Request Money** lets your friends pay you back directly in Expensify. When you send a payment request to a friend, Expensify will display the amount owed and the option to pay the corresponding request in a chat between you.
+
+**Split Bill** allows you to split payments between friends and ensures the person who settled the tab gets paid back.
+
+These two features ensure you can live in the moment and settle up afterward.
+
+# How to Request Money
+- Select the Green **+** button and choose **Request Money**
+- Enter the amount **$** they owe and click **Next**
+- Search for the user or enter their email!
+- Enter a reason for the request (optional)
+- Click **Request!**
+- If you change your mind, all you have to do is click **Cancel**
+- The user will be able to **Settle up outside of Expensify** or pay you via **Venmo** or **PayPal.me**
+
+# How to Split a Bill
+- Select the Green **+** button and choose **Split Bill**
+- Enter the total amount for the bill and click **Next**
+- Search for users or enter their emails and **Select**
+- Enter a reason for the split
+- The split is then shared equally between the attendees
+
+# FAQs
+## Can I request money from more than one person at a time?
+If you need to request money for more than one person at a time, you’ll want to use the Split Bill feature. The Request Money option is for one-to-one payments between two people.

docs/articles/split-bills/paying-friends/Request-and-Split-Bills.md

@@ -0,0 +1,35 @@
+---
+title: Request Money and Split Bills with Friends
+description: Everything you need to know about Requesting Money and Splitting Bills with Friends!
+---
+
+<!-- The lines above are required by Jekyll to process the .md file -->
+
+# How do these Payment Features work?
+Our suite of money movement features enables you to request money owed by an individual or split a bill with a group.
+
+**Request Money** lets your friends pay you back directly in Expensify. When you send a payment request to a friend, Expensify will display the amount owed and the option to pay the corresponding request in a chat between you.
+
+**Split Bill** allows you to split payments between friends and ensures the person who settled the tab gets paid back.
+
+These two features ensure you can live in the moment and settle up afterward.
+
+# How to Request Money
+- Select the Green **+** button and choose **Request Money**
+- Enter the amount **$** they owe and click **Next**
+- Search for the user or enter their email!
+- Enter a reason for the request (optional)
+- Click **Request!**
+- If you change your mind, all you have to do is click **Cancel**
+- The user will be able to **Settle up outside of Expensify** or pay you via **Venmo** or **PayPal.me**
+
+# How to Split a Bill
+- Select the Green **+** button and choose **Split Bill**
+- Enter the total amount for the bill and click **Next**
+- Search for users or enter their emails and **Select**
+- Enter a reason for the split
+- The split is then shared equally between the attendees
+
+# FAQs
+## Can I request money from more than one person at a time?
+If you need to request money for more than one person at a time, you’ll want to use the Split Bill feature. The Request Money option is for one-to-one payments between two people.

docs/hubs/send-money.html → docs/hubs/split-bills.html

@@ -1,6 +1,6 @@
 ---
 layout: default
-title: Send money
+title: Split bills
 ---
 
 {% include hub.html %}

docs/index.html

@@ -11,7 +11,7 @@ <h2>
     </h2>
 
     <div class="cards-group">
-        {% include hub-card.html href="send-money" %}
+        {% include hub-card.html href="split-bills" %}
         {% include hub-card.html href="request-money" %}
         {% include hub-card.html href="playbooks" %}
         {% include hub-card.html href="other" %}

src/libs/IOUUtils.js

@@ -127,7 +127,7 @@ function isIOUReportPendingCurrencyConversion(reportActions, iouReport) {
  * @returns {Boolean}
  */
 function isValidMoneyRequestType(iouType) {
-    return [CONST.IOU.MONEY_REQUEST_TYPE.REQUEST, CONST.IOU.MONEY_REQUEST_TYPE.SEND, CONST.IOU.MONEY_REQUEST_TYPE.SPLIT].includes(iouType);
+    return [CONST.IOU.MONEY_REQUEST_TYPE.REQUEST, CONST.IOU.MONEY_REQUEST_TYPE.SPLIT].includes(iouType);
 }
 
 export {calculateAmount, updateIOUOwnerAndTotal, getIOUReportActions, isIOUReportPendingCurrencyConversion, isValidMoneyRequestType};

src/libs/Permissions.js

@@ -43,11 +43,12 @@ function canUseDefaultRooms(betas) {
 }
 
 /**
- * @param {Array<String>} betas
+ * IOU Send feature is temporarily disabled.
+ *
  * @returns {Boolean}
  */
-function canUseIOUSend(betas) {
-    return _.contains(betas, CONST.BETAS.IOU_SEND) || canUseAllBetas(betas);
+function canUseIOUSend() {
+    return false;
 }
 
 /**

tests/unit/IOUUtilsTest.js

@@ -159,12 +159,12 @@ describe('IOUUtils', () => {
 
 describe('isValidMoneyRequestType', () => {
     test('Return true for valid iou type', () => {
-        expect(IOUUtils.isValidMoneyRequestType('send')).toBe(true);
         expect(IOUUtils.isValidMoneyRequestType('request')).toBe(true);
         expect(IOUUtils.isValidMoneyRequestType('split')).toBe(true);
     });
 
     test('Return false for invalid iou type', () => {
+        expect(IOUUtils.isValidMoneyRequestType('send')).toBe(false);
         expect(IOUUtils.isValidMoneyRequestType('money')).toBe(false);
     });
 });