Merge pull request #39181 from margelo/feat/more-startup-marks

[NoQA] feat: more startup marks
Expensify · Apr 2, 2024 · bf1ec5a · bf1ec5a
2 parents 5cdfbb7 + 3665025
commit bf1ec5a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/android/app/src/main/java/com/expensify/chat/MainActivity.kt b/android/app/src/main/java/com/expensify/chat/MainActivity.kt
@@ -14,6 +14,8 @@ import com.facebook.react.ReactActivityDelegate
 import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.fabricEnabled
 import com.facebook.react.defaults.DefaultReactActivityDelegate
 
+import com.oblador.performance.RNPerformance
+
 class MainActivity : ReactActivity() {
     /**
      * Returns the name of the main component registered from JavaScript. This is used to schedule
@@ -82,4 +84,9 @@ class MainActivity : ReactActivity() {
         KeyCommandModule.getInstance().onKeyDownEvent(keyCode, event)
         return super.onKeyUp(keyCode, event)
     }
+
+    override fun onStart() {
+        super.onStart()
+        RNPerformance.getInstance().mark("appCreationEnd", false);
+    }
 }
diff --git a/android/app/src/main/java/com/expensify/chat/MainApplication.kt b/android/app/src/main/java/com/expensify/chat/MainApplication.kt
@@ -15,6 +15,7 @@ import com.facebook.react.defaults.DefaultReactNativeHost
 import com.facebook.react.modules.i18nmanager.I18nUtil
 import com.facebook.soloader.SoLoader
 import com.google.firebase.crashlytics.FirebaseCrashlytics
+import com.oblador.performance.RNPerformance
 import expo.modules.ApplicationLifecycleDispatcher
 import expo.modules.ReactNativeHostWrapper
 
@@ -42,6 +43,8 @@ class MainApplication : MultiDexApplication(), ReactApplication {
     override fun onCreate() {
         super.onCreate()
 
+        RNPerformance.getInstance().mark("appCreationStart", false);
+
         if (isOnfidoProcess()) {
             return
         }

diff --git a/src/libs/Performance.tsx b/src/libs/Performance.tsx
@@ -134,6 +134,13 @@ if (Metrics.canCapturePerformanceMetrics()) {
                 if (entry.name === 'runJsBundleEnd') {
                     Performance.measureFailSafe('runJsBundle', 'runJsBundleStart', 'runJsBundleEnd');
                 }
+                if (entry.name === 'appCreationEnd') {
+                    Performance.measureFailSafe('appCreation', 'appCreationStart', 'appCreationEnd');
+                    Performance.measureFailSafe('nativeLaunchEnd_To_appCreationStart', 'nativeLaunchEnd', 'appCreationStart');
+                }
+                if (entry.name === 'contentAppeared') {
+                    Performance.measureFailSafe('appCreationEnd_To_contentAppeared', 'appCreationEnd', 'contentAppeared');
+                }
 
                 // We don't need to keep the observer past this point
                 if (entry.name === 'runJsBundleEnd' || entry.name === 'downloadEnd') {
@@ -154,6 +161,7 @@ if (Metrics.canCapturePerformanceMetrics()) {
 
                 // Capture any custom measures or metrics below
                 if (mark.name === `${CONST.TIMING.SIDEBAR_LOADED}_end`) {
+                    Performance.measureFailSafe('contentAppeared_To_screenTTI', 'contentAppeared', mark.name);
                     Performance.measureTTI(mark.name);
                 }
             });
@@ -163,6 +171,10 @@ if (Metrics.canCapturePerformanceMetrics()) {
     Performance.getPerformanceMetrics = (): PerformanceEntry[] =>
         [
             ...rnPerformance.getEntriesByName('nativeLaunch'),
+            ...rnPerformance.getEntriesByName('nativeLaunchEnd_To_appCreationStart'),
+            ...rnPerformance.getEntriesByName('appCreation'),
+            ...rnPerformance.getEntriesByName('appCreationEnd_To_contentAppeared'),
+            ...rnPerformance.getEntriesByName('contentAppeared_To_screenTTI'),
             ...rnPerformance.getEntriesByName('runJsBundle'),
             ...rnPerformance.getEntriesByName('jsBundleDownload'),
             ...rnPerformance.getEntriesByName('TTI'),