Skip to content

Commit

Permalink
Add comment for exhaustive dependencies ESlint skipping
Browse files Browse the repository at this point in the history
  • Loading branch information
ShridharGoel committed Apr 2, 2024
1 parent 76719bb commit aa15e02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/VideoPlayer/BaseVideoPlayer.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function BaseVideoPlayer({
videoStateRef.current = e;
onPlaybackStatusUpdate(e);
},
// eslint-disable-next-line react-hooks/exhaustive-deps
// eslint-disable-next-line react-hooks/exhaustive-deps -- we don't want to trigger this when isPlaying changes because isPlaying is only used inside shouldReplayVideo
[onPlaybackStatusUpdate, preventPausingWhenExitingFullscreen, videoDuration],
);

Expand Down

0 comments on commit aa15e02

Please sign in to comment.