Merge pull request #44882 from nkdengineer/fix/44801

[CP Staging] Fix select all checkbox is not checked when all items are checked
Expensify · Jul 5, 2024 · 87f5cdd · 87f5cdd
2 parents 9d4cae0 + 6d0edab
commit 87f5cdd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/components/SelectionList/BaseSelectionList.tsx b/src/components/SelectionList/BaseSelectionList.tsx
@@ -166,7 +166,7 @@ function BaseSelectionList<TItem extends ListItem>(
                 itemLayouts.push({length: fullItemHeight, offset});
                 offset += fullItemHeight;
 
-                if (item.isSelected && !selectedOptions.find((option) => option.text === item.text)) {
+                if (item.isSelected && !selectedOptions.find((option) => option.keyForList === item.keyForList)) {
                     selectedOptions.push(item);
                 }
             });

diff --git a/src/libs/SearchUtils.ts b/src/libs/SearchUtils.ts
@@ -167,6 +167,7 @@ function getReportSections(data: OnyxTypes.SearchResults['data'], metadata: Onyx
 
             reportIDToTransactions[reportKey] = {
                 ...value,
+                keyForList: value.reportID,
                 from: data.personalDetailsList?.[value.accountID],
                 to: data.personalDetailsList?.[value.managerID],
                 transactions,