chore: remove gradle duplicates from composite builds #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to keep intellij "happy" we need to have `gradle/wrapper/gradle.properties` (as otherwise it will attempt to recreate it). In order to avoid duplication of having multiple wrappers (oneper each composite build) potentially running different versions of Gradle, I've updated them to follow symbolic links instead. NOTE: this change introduces linux symbolic links which means they will not work for Windows machines. It is inconvenient but it is the simplest way to dedup those scripts. Windows users will have to execute `gradlew.bat` from root dir OR invoke Gradle directly.
dariuszkuc
changed the title
dariuszkuc
changed the title
|
looks like bump to gradle v8 requires some additional changes -> will use separate PR for that |
samuelAndalon
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
In order to keep intellij "happy" we need to have
gradle/wrapper/gradle.properties(as otherwise it will attempt to recreate it). In order to avoid duplication of having multiple wrappers (oneper each composite build) potentially running different versions of Gradle, I've updated them to follow symbolic links instead.NOTE: this change introduces linux symbolic links which means they will not work for Windows machines. It is inconvenient but it is the simplest way to dedup those scripts. Windows users will have to execute
gradlew.batfrom root dir OR invoke Gradle directly.🔗 Related Issues
N/A