[ktor server] simplify KtorGraphQLRequestParser #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can rely on `ContentNegotiation` plugin to automatically parse incoming requests for us. We don't have to read incoming requests as plain text and then attempt to manually map it.
dariuszkuc
added
changes: patch
| @@ -61,9 +60,8 @@ class KtorGraphQLRequestParser( | |||
| } | |||
|
|
|||
| private suspend fun parsePostRequest(request: ApplicationRequest): GraphQLServerRequest? = try { | |||
| val rawRequest = request.call.receiveText() | |||
| mapper.readValue(rawRequest, GraphQLServerRequest::class.java) | |||
| request.call.receive() | |||
There was a problem hiding this comment.
how does the ApplicationRequest instance know to which type the request payload needs to be deserialized to ? is it an inlineClass ?
request.call.receive<GraphQLServerRequest>()There was a problem hiding this comment.
type inference from the method return type -> since Jackson content negotiation is installed on the route it will deserialize it to appropriate GraphQLServerRequest (single or batch)
There was a problem hiding this comment.
and yes receive is inline reified method
samuelAndalon
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We can rely on
ContentNegotiationplugin to automatically parse incoming requests for us. We don't have to read incoming requests as plain text and then attempt to manually map it.🔗 Related Issues