Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JDK11 build step #168

Merged
merged 4 commits into from
Feb 19, 2019
Merged

Add JDK11 build step #168

merged 4 commits into from
Feb 19, 2019

Conversation

gscheibel
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 18, 2019 •
edited
Loading

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #168   +/-   ##
=========================================
  Coverage     97.89%   97.89%           
  Complexity      153      153           
=========================================
  Files            55       55           
  Lines           523      523           
  Branches         90       90           
=========================================
  Hits            512      512           
  Misses            7        7           
  Partials          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 055e784...727e7eb. Read the comment docs.

@smyrick
Copy link
Contributor

smyrick commented Feb 18, 2019

We are having build issues with Dokka on JDK 11. It looks like it is unsupported right now Kotlin/dokka#294

@dariuszkuc dariuszkuc merged commit 248869d into master Feb 19, 2019
@dariuszkuc dariuszkuc deleted the openJDK11 branch February 19, 2019 14:21
@smyrick smyrick added the type: tool update CI, code coverage, or linter updates label Mar 6, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
@gscheibel @dariuszkuc
Add JDK11 build step (ExpediaGroup#168)
6f85c6b 
* Add JDK11 build step

* Switch to openjdk 8 instead of oracle jdk 8

* Switch default build to openjdks

* Only activate the dokka plugin when the JDK8 is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariuszkuc dariuszkuc dariuszkuc approved these changes

Assignees
No one assigned
Labels
type: tool update CI, code coverage, or linter updates
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gscheibel @smyrick @dariuszkuc