Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new Spring Boot auto-configuration #1609

Closed
snv opened this issue Dec 6, 2022 · 1 comment · Fixed by #1638
Closed

use new Spring Boot auto-configuration #1609

snv opened this issue Dec 6, 2022 · 1 comment · Fixed by #1638
Labels
changes: major Changes require a major version module: server Issue affects the server code
Milestone
7.0.0

Comments

@snv
Copy link

snv commented Dec 6, 2022

Library Version
com.expediagroup:graphql-kotlin-spring-server:7.0.0-alpha.0

Describe the bug
When switchen to Spring Boot 3 com.expediagroup.graphql.server.spring.GraphQLAutoConfiguration does not get executed, because the old way of registering them via spring.factories has been removed.
The new way needs a META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports-File.

Additional Info
Details about the introduction of the new mechanism, and the deactivation of the old one.

As a workaround i can get my project to work, by registering com.expediagroup.graphql.server.spring.GraphQLAutoConfiguration myself with a META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports in my own application.
@snv snv added the type: bug Something isn't working label Dec 6, 2022
@samuelAndalon samuelAndalon added this to the 7.0.0 milestone Dec 7, 2022
@samuelAndalon samuelAndalon added changes: major Changes require a major version module: server Issue affects the server code and removed type: bug Something isn't working labels Dec 9, 2022
@dariuszkuc dariuszkuc mentioned this issue Jan 16, 2023
Merged
@hantsy
Copy link

hantsy commented Jan 22, 2023

As a workaround i can get my project to work, by registering com.expediagroup.graphql.server.spring.GraphQLAutoConfiguration myself with a META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports in my own application.

Alternatively, add @ImportAutoConfiguration on your Spring application class to import it manually.

dariuszkuc added a commit that referenced this issue Jan 27, 2023
@dariuszkuc
update to SpringBoot 3 and Java 17 (#1638)
1fbbd48 
### 📝 Description

SpringBoot v3 requires Java 17. This PR updates target bytecode of ALL `graphql-kotlin` modules to Java 17 and as a result ibrary users will have to use Java 17+ as well.

### 🔗 Related Issues
* Resolves #1609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changes: major Changes require a major version module: server Issue affects the server code
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

update to SpringBoot 3 and Java 17 dariuszkuc/graphql-kotlin
3 participants
@hantsy @snv @samuelAndalon