Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the user provides a resolution value if the input map is in MRC/CCP4 or MAP formats #180

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

ashrayar
Copy link
Collaborator

@ashrayar ashrayar commented Apr 20, 2022

Pull Request Checklist

  • Will your PR merge into the dev branch?
    Exceptions will be made for urgent bugfixes.
  • Have you forked from dev?
    If not, please rebase your PR onto the most recent dev tip.
  • Does your PR title succinctly describe the changes?
    Explain to a new user by completing the sentence: 'This PR will: ...'
  • Fill out the template below.

Description of the Change

This fix adds a check to make sure the user provides a resolution value if the input map is in MRC/CCP4 or MAP formats. If not provided, raises an error and stops.

Release Notes

  • If using a real-space map, the user must provide a resolution value

@ashrayar ashrayar changed the base branch from main to dev April 20, 2022 22:41
@blake-riley blake-riley changed the title This PR adds a check to make sure the user provides a resolution value if the input map is in MRC/CCP4 or MAP formats Make sure the user provides a resolution value if the input map is in MRC/CCP4 or MAP formats Apr 21, 2022
@blake-riley blake-riley merged commit c2db748 into dev Apr 21, 2022
@blake-riley blake-riley deleted the Resolution-argument-for-CCP4-maps branch April 21, 2022 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants