feat(rpc/orderbook): handle remove order with hold #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
sangaman
force-pushed
the
remove-order-hold
branch
from
aacc958 to
44066e5
Compare
This handles the possibility that we attempt to remove an order via the rpc layer while that order has a hold for a pending swap. Instead of removing the entire order immediately, this only removes the available portion of the order and then waits until any swaps finish before removing the portions that were on hold. It also adds a field to the `RemoveOrder` rpc response which indicates whether any portion of the order was on hold. This gives feedback up front as to whether an order was removed immediately, or whether there are ongoing swaps which are being allowed to finish. Closes #552.
sangaman
force-pushed
the
remove-order-hold
branch
from
44066e5 to
943a811
Compare
moshababo
reviewed
Dec 3, 2018
sangaman
force-pushed
the
remove-order-hold
branch
from
943a811 to
6bd0468
Compare
|
@moshababo I addressed your feedback, still have one open item about the timeouts, let me know what you think. I believe I'm preventing putting more quantity on hold by removing all the quantity from the order up front that isn't on hold here. Therefore the order can no longer be matched/swapped and won't get any additional holds. |
This adds assertions to the `removeOrder` logic to ensure that we do not remove any portion of an order that is currently on hold.
sangaman
force-pushed
the
remove-order-hold
branch
from
6bd0468 to
9350a27
Compare
Agree, missed that. |
moshababo
approved these changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #552.
This handles the possibility that we attempt to remove an order via the rpc layer while that order has a hold for a pending swap. Instead of removing the entire order immediately, this only removes the available portion of the order and then waits until any swaps finish before removing the portions that were on hold.
It also adds a field to the
RemoveOrderrpc response which indicates whether any portion of the order was on hold. This gives feedback up front as to whether an order was removed immediately, or whether there are ongoing swaps which are being allowed to finish.It also adds some assertions to the
removeOrderlogic to ensure that we don't try to remove any part of an order that is on hold.