feat(lnd): SendPaymentV2 #1971
Merged
feat(lnd): SendPaymentV2 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sangaman
force-pushed
the
lnd/sendpaymentv2
branch
4 times, most recently
from
3ecffe0 to
2926b63
Compare
|
Simulation tests are passing now so this is ready for review/further testing. I'm working on a simulation test case for a multi path payments but unless I get it working soon it'd make sense to leave for a future PR. |
Open
raladev
previously approved these changes
Nov 4, 2020
|
I'll fix the conflict and merge, it'll need another quick approval afterwards. |
This migrates the call we use to send payments with lnd from the deprecated `SendPaymentSync` to `SendPaymentV2` which allows for multi path payments, among other improvements. As part of this change, the lnd proto files have been updated to their v0.11.x versions and the version of lnd used in simulation tests has been updated to v0.11.1 as well. Closes #1590.
sangaman
force-pushed
the
lnd/sendpaymentv2
branch
from
2926b63 to
51c60dc
Compare
|
Rebased to fix the conflict. Just needs an approval then we can merge this. |
ghost
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the call we use to send payments with lnd from the deprecated
SendPaymentSynctoSendPaymentV2which allows for multi path payments, among other improvements. As part of this change, the lnd proto files have been updated to their v0.11.x versions and the version of lnd used in simulation tests has been updated to v0.11.1 as well.Closes #1590.
I'll open a related PR to our lnd config in xud-docker to enable MPP.
Simulation tests aren't running on my machine with these changes, so I'm opening this as a draft to see if there's any difference running them on GitHub Actions. I'll mark it as ready once I get simulation tests pasing.