Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect contract address when adding native ETH #1957

Closed
raladev opened this issue Oct 22, 2020 · 1 comment · Fixed by #1959
Closed

Incorrect contract address when adding native ETH #1957

raladev opened this issue Oct 22, 2020 · 1 comment · Fixed by #1959
Assignees
@rsercano
Labels
bug Something isn't working P3 low priority

Comments

@raladev
Copy link
Contributor

raladev commented Oct 22, 2020

Steps:

  1. remove pair ETH/BTC
  2. removecurrency ETH
  3. addcurrency ETH Connext 18 0x0000000000000000000000000000000000000000
  4. listcurrencies

Actual result:
Incorrect token address. As a result connext client cant get data for ETH from indra node.

ETH    │ 18     │ 0x0                                        │ Connext

Screenshot from 2020-10-22 15-50-54

Expected result:

 ETH    │ 18     │ 0x0000000000000000000000000000000000000000 │ Connext
@raladev raladev added bug Something isn't working P3 low priority labels Oct 22, 2020
@raladev raladev changed the title incorrect convertation of conntract addresss incorrect convertation of contract address Oct 22, 2020
@kilrau kilrau assigned rsercano and unassigned kilrau Oct 22, 2020
@kilrau
Copy link
Contributor

kilrau commented Oct 22, 2020

Want to look into this? @rsercano

@kilrau kilrau changed the title incorrect convertation of contract address Incorrect contract address when adding native ETH Oct 23, 2020
rsercano added a commit that referenced this issue Oct 23, 2020
@rsercano
fix:incorrect address conversion for connext currencies while adding (#…
c5d7ba6 
…1957)
@rsercano rsercano mentioned this issue Oct 23, 2020
Merged
rsercano added a commit that referenced this issue Oct 23, 2020
@rsercano
fix:incorrect address conversion for connext currencies while adding (#…
9d85c89 
…1957)
sangaman added a commit that referenced this issue Oct 27, 2020
@sangaman
Merge pull request #1959 from ExchangeUnion/fix/addcurrency-yargs-con…
41d103c 
…next-address-#1957

fix:incorrect address conversion for connext currencies while adding currencies #1957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
bug Something isn't working P3 low priority
Projects
None yet
Milestone
No milestone
3 participants
@rsercano @kilrau @raladev