fix: alias missing in streamorders (#1725)

ExchangeUnion · Oct 27, 2020 · 6699e62 · 6699e62
1 parent 41d103c
commit 6699e62
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 5 deletions.
diff --git a/lib/grpc/GrpcService.ts b/lib/grpc/GrpcService.ts
@@ -53,6 +53,7 @@ const createOrder = (order: Order) => {
   } else {
     const nodeIdentifier = new xudrpc.NodeIdentifier();
     nodeIdentifier.setNodePubKey(order.peerPubKey);
+    nodeIdentifier.setAlias(order.alias);
     grpcOrder.setNodeIdentifier(nodeIdentifier);
     grpcOrder.setIsOwnOrder(false);
   }

diff --git a/lib/orderbook/types.ts b/lib/orderbook/types.ts
@@ -67,7 +67,9 @@ type Local = {
 /** Properties that apply only to orders placed by remote peers. */
 type Remote = {
   /** The nodePubKey of the node which created this order. */
-  peerPubKey: string;
+  peerPubKey: string,
+  /** The alias of the node which created this order. */
+  alias: string;
 };
 
 /** Properties that uniquely identify an order and make it ready to enter the order book. */

diff --git a/lib/p2p/Pool.ts b/lib/p2p/Pool.ts
@@ -780,7 +780,7 @@ class Pool extends EventEmitter {
             this.emit('packet.orderInvalidation', orderInvalidation, peer.nodePubKey!);
           }
 
-          const incomingOrder: IncomingOrder = { ...receivedOrder, peerPubKey: peer.nodePubKey! };
+          const incomingOrder: IncomingOrder = { ...receivedOrder, peerPubKey: peer.nodePubKey!, alias: peer.alias! };
           this.emit('packet.order', incomingOrder);
         } else {
           this.logger.debug(`received order ${id} for deactivated trading pair`);
@@ -809,7 +809,7 @@ class Pool extends EventEmitter {
           this.logger.debug(`received ${receivedOrders.length} orders from ${peer.label}`);
           receivedOrders.forEach((order) => {
             if (peer.isPairActive(order.pairId)) {
-              this.emit('packet.order', { ...order, peerPubKey: peer.nodePubKey! });
+              this.emit('packet.order', { ...order, peerPubKey: peer.nodePubKey!, alias: peer.alias! });
             } else {
               this.logger.debug(`received order ${order.id} for deactivated trading pair`);
             }

diff --git a/lib/service/Service.ts b/lib/service/Service.ts
@@ -694,13 +694,20 @@ class Service extends EventEmitter {
     cancelled$: Observable<void>,
   ) => {
     if (args.existing) {
+      function setAlias(pool: Pool) {
+        return (order: PeerOrder) => {
+          order.alias = pool.getNodeAlias(order.peerPubKey)!;
+          callback(order);
+        };
+      }
+
       this.orderBook.pairIds.forEach((pair) => {
         const ownOrders = this.orderBook.getOwnOrders(pair);
         const peerOrders = this.orderBook.getPeersOrders(pair);
         ownOrders.buyArray.forEach(order => callback(order));
-        peerOrders.buyArray.forEach(order => callback(order));
+        peerOrders.buyArray.forEach(setAlias(this.pool));
         ownOrders.sellArray.forEach(order => callback(order));
-        peerOrders.sellArray.forEach(order => callback(order));
+        peerOrders.sellArray.forEach(setAlias(this.pool));
       });
     }
 

diff --git a/test/utils.ts b/test/utils.ts
@@ -79,6 +79,7 @@ export const createPeerOrder = (
   isBuy: boolean,
   createdAt = ms(),
   peerPubKey = '029a96c975d301c1c8787fcb4647b5be65a3b8d8a70153ff72e3eac73759e5e345',
+  alias = 'test_alias',
   pairId = 'LTC/BTC',
 ): PeerOrder => ({
   quantity,
@@ -87,6 +88,7 @@ export const createPeerOrder = (
   pairId,
   createdAt,
   peerPubKey,
+  alias,
   initialQuantity: quantity,
   id: uuidv1(),
 });