Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Gotchas and incompatibilities in build script #38

Closed
logological opened this issue Jun 28, 2017 · 1 comment
Closed

Gotchas and incompatibilities in build script #38

logological opened this issue Jun 28, 2017 · 1 comment

Comments

@logological
Copy link

The build.sh script is not written in a way that will work with all Bourne-compatible shells, and uses globbing in dangerous ways. In particular:

  • Commands such as echo "-u:enable update" can be misinterpreted as passing a command-line parameter to echo
  • Globbing in lines such as zip -r exchangecalendar-v$version.xpi * … could end up passing command-line parameters to zip if there exist filenames starting with a hyphen
  • Variable substitution in lines such as zip -r exchangecalendar-v$version.xpi … could result in unwanted word splitting, depending on the value of $version.
advancingu added a commit that referenced this issue Jun 28, 2017
Delint build script. ExchangeCalendar/exchangecalendar/#38
@advancingu
Copy link
Member

Merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants