Adding start/end time to all day event leads to 24h event starting at 0:00 #286
Comments
(i.e. no longer being an all day event), the order of the transmitted properties matters for OWA. So the all day property has to be transmitted before the start/end times, as otherwise the desired times are not applied. Closes ExchangeCalendar#286.
When an all day event is modified to have start/end times (i.e. no longer being an all day event), the order of the transmitted properties matters for OWA. So the all day property has to be transmitted before the start/end times, as otherwise the desired times are not applied. Closes ExchangeCalendar#286.
|
I am experiencing a quite similar issue but it happens any time I create an "all day event" for the day X, I don't need to change it later by setting start/end times. The results is that the event is extended to day X+1. |
|
Creating an all day event itself doesn't lead to such behaviour in my case. Maybe different Outlook server versions are involved here. I don't have code knowledge that is deep enough to be able to estimate if it fixes your issue, too. But if you want to try the fixed version yourself: https://basicmaster.de/test/exchangecalendar-v5.0.0-alpha3_SP.xpi |
|
I installed the version with your fix but my issue persists. |
|
It seems that your issue affects a different code part (creation vs. change). So I propose that you create a new issue (refering to this one as related) to describe the problem, as this one will get closed when the related fix is merged. |
…day-event #286 Fix adding times to all day event
|
Should be fixed now. |
(tested with
v5.0.0-alpha3branch)It sometimes happens that I create an event for day X as an all day event, as I don't know the schedule yet. Some time later I want to add the actual start/end times. Setting these times (unchecking the all day checkbox) shows the correct times for a moment after saving the event. However after the event is reloaded from the server, the event is then an event starting from 0:00 on day X, going until 0:00 on day X+1. In the original Outlook Web App, this is no problem in contrast.
Steps to reproduce this:
Investigating this, the following results:
Comparing the request of this plugin to the request of the Outlook Web App, it turns out that OWA (using JSON) transmits the
IsAllDayEventfield before theStartandEndfields - the order seems to matter here. Assuming that all changed fields are processed in the transmitted order, it seems (comparatively) reasonable that a start/end time update on an all day event doesn't really make sense and leads to that strange times....just moments before the all day property is set tofalsesome lines below.Hence switching the order - first unsetting the all day property, then setting the times - indeed fixes the issue. So adding start/end times to an all day event now works flawlessly. I will open a PR for this in a moment...
The text was updated successfully, but these errors were encountered: