Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable definition of constraints from a 6-DOF (base) node to a 3-DOF (target) node #327

Merged
merged 62 commits into from
Jan 17, 2025
Merged

Enable definition of constraints from a 6-DOF (base) node to a 3-DOF (target) node #327

merged 62 commits into from
Jan 17, 2025

Conversation

faisal-bhuiyan
Copy link
Collaborator

@faisal-bhuiyan faisal-bhuiyan commented Dec 30, 2024 •
edited
Loading

Provides an implementation for this. Also implements the heavy top test.

@faisal-bhuiyan faisal-bhuiyan self-assigned this Dec 30, 2024
@faisal-bhuiyan faisal-bhuiyan changed the title Implement rigid constraint definition from a 6-DOF (base) node to a 3-DOF (target) node Enable definition of rigid constraints from a 6-DOF (base) node to a 3-DOF (target) node Dec 30, 2024
@faisal-bhuiyan
Add unit tests for Constraint struct
b13f4cc
@faisal-bhuiyan
Refactor Constraints struct + get it under unit test coverage
b17edfb
@faisal-bhuiyan
Refactor the system kernels of constraints to look similar to element…
1ace07b 
…s kernels + refactors throughout to use if blocks instead of switch blocks for clean code
@faisal-bhuiyan
Start adding unit tests for CreateConstraintFreedomTable -- begin wit…
8fd1d5c 
…h FixedBC case
@faisal-bhuiyan
Complete the unit test suite for create_constraint_freedom_table() by…
ec4e03c 
… adding cases for PrescribedBC, RigidJoint, and RevoluteJoint
@faisal-bhuiyan
Add RigidJoint3DOFs to the type of constaints
de8c342
@faisal-bhuiyan
Minor tweaks to unit tests for create_constraint_freedom_table()
9b85db4
@faisal-bhuiyan
Minor fixes to make static analyzers happy
9c61c96
@faisal-bhuiyan
Merge branch 'main' into 6-to-3-dof-rigid-constraint
5dad936
@faisal-bhuiyan
Remove the kRigidJoint3DOF type from ConstraintType enum since we sho…
0bd5bba 
…uld not need a specific type of constraint to achieve what we need
@faisal-bhuiyan
Merge branch 'main' into 6-to-3-dof-rigid-constraint
bf669fa
@faisal-bhuiyan
Refactor c-tor of Constraints to create modularity + other minor impr…
361eaeb 
…ovements
@faisal-bhuiyan
Add annotations to FreedomSignature and related functions to increase…
9d5e588 
… readability
@faisal-bhuiyan
Minor fixes
1481a32
@faisal-bhuiyan
Add node_num_dofs attribute to Constraint class to keep track of the …
ec5fc4c 
…base + target node dofs
@faisal-bhuiyan
Bring back the unit tests for Constraint and Constraints structs
4741418
@faisal-bhuiyan
Add attribute node_num_dofs to Constraints + use it to modify the log…
de4575b 
…ic in CalculatePrescribedBCConstraint & CalculateRigidJointConstraint functors
@faisal-bhuiyan
Minor fixes to Model class to add num_dofs to AddRigidJointConstraint
989d1a1
@faisal-bhuiyan
Add preliminary implementation of the heavy top problem
2503490
@faisal-bhuiyan
Add node_num_dofs to CalculateFixedBCConstraint + other minor fixes
c157bde
@faisal-bhuiyan
Refactor unit tests for create_constraint_freedom_table()
1c30aa7
@faisal-bhuiyan
clang-tidy fix
63fc213
@faisal-bhuiyan
Clang-tidy fixes
ffb55b5
@faisal-bhuiyan
Add active_dofs attribute to Node struct to manage the FreedomSignatu…
baa5b15 
…re at the node level
@faisal-bhuiyan
Add a default c-tor to Elements class to create an empty object to fa…
785ed29 
…cilitate with unit testing
faisal-bhuiyan and others added 9 commits January 16, 2025 14:24
@faisal-bhuiyan faisal-bhuiyan marked this pull request as ready for review January 17, 2025 01:55
@faisal-bhuiyan faisal-bhuiyan added enhancement New feature or request code-refactoring Refactoring code to improve readability, maintainability, efficiency etc. labels Jan 17, 2025
@faisal-bhuiyan faisal-bhuiyan changed the title Enable definition of rigid constraints from a 6-DOF (base) node to a 3-DOF (target) node Enable definition of constraints from a 6-DOF (base) node to a 3-DOF (target) node Jan 17, 2025
deslaughter
deslaughter approved these changes Jan 17, 2025
View reviewed changes
src/model/copy_nodes_to_state.hpp Outdated Show resolved Hide resolved
src/model/copy_nodes_to_state.hpp Outdated Show resolved Hide resolved
src/model/copy_nodes_to_state.hpp Outdated Show resolved Hide resolved
src/model/model.hpp Show resolved Hide resolved
src/constraints/constraints.hpp Show resolved Hide resolved
ddement
ddement approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ddement ddement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you make the changes I note, everything will run pass on GPU

src/constraints/constraint_type.hpp Outdated Show resolved Hide resolved
src/constraints/constraint_type.hpp Outdated Show resolved Hide resolved
@faisal-bhuiyan faisal-bhuiyan merged commit 9d6c18b into main Jan 17, 2025
17 checks passed
@faisal-bhuiyan faisal-bhuiyan deleted the 6-to-3-dof-rigid-constraint branch January 17, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddement ddement ddement approved these changes

@deslaughter deslaughter deslaughter approved these changes

Assignees

@faisal-bhuiyan faisal-bhuiyan

Labels
code-refactoring Refactoring code to improve readability, maintainability, efficiency etc. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faisal-bhuiyan @ddement @deslaughter