Donelan Heat Flux Calculation to Work in HEAT_FLUX Mode #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2024 14:28
…FLUX and SURFACE_TEMPERATURE mode. Right now, it does not work properly in HEAT_FLUX mode.
adding an abl bc test for the donelan wall model
|
Tested this with CPU and GPU. All works. |
gdeskos
approved these changes
Feb 21, 2024
|
@mbkuhn, since I have no merging rights anymore, would you be able to review and merge ? We need this asap! |
mbkuhn
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a switch to the Donelan wall temperature flux model so that if the user specifies heat flux (HEAT_FLUX mode in MOData), Donelan just uses it rather than tries to recompute it with the 0.0012 * wspd_mean * (theta_surface - theta_mean) formula. That formula should only be used if the user specifies a surface temperature (SURFACE_TEMPERATURE mode in MOData).