Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The initial immersed forcing model marks the cell as binary (0 for outside terrain and 1 for partially/fully in terrain). In this PR we extend the method to allow for a partial cell cut. This is accomplished by assuming that the terrain can be based on the face-distant terrain height in each cell. This method is not as accurate as AMReX EB method but makes it easier to handle large wind farms since the STL size for these farms can be of the order of few GBs while the interpolation method for marking terrain is instantaneous.
The terrain_blank variable is not modified since it will also be used for ocean waves. The new variable terrain_vf stores the value of the volume fraction. This can be modified in the future if required.
Please check the type of change introduced:
The existing terrain test case can be run using this method and there is no need for new unit and regression tests.
Comparison of proposed method (top) and existing (bottom)