Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added NESO-Particles 0.6.0 and 0.7.0 with petsc variant #48

Merged
merged 4 commits into from
Jan 16, 2025
Merged

added NESO-Particles 0.6.0 and 0.7.0 with petsc variant #48

merged 4 commits into from
Jan 16, 2025

Conversation

will-saunders-ukaea
Copy link
Collaborator

  • Adds NP v0.6.0 and v0.7.0
  • Adds PETSc variant + dependency for NP

@oparry-ukaea oparry-ukaea self-requested a review December 11, 2024 15:07
oparry-ukaea
oparry-ukaea approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@oparry-ukaea oparry-ukaea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
neso-particles+petsc and neso-particles+nvcxx both build for me;
Encountered some issues building neso+nvcxx but they're not related to this PR.

@will-saunders-ukaea will-saunders-ukaea merged commit 153b677 into main Jan 16, 2025
@will-saunders-ukaea will-saunders-ukaea deleted the feature/add_np_0.7.0 branch January 16, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oparry-ukaea oparry-ukaea oparry-ukaea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@will-saunders-ukaea @oparry-ukaea