Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix async append result in different order issue #244

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Conversation

kcz358
Copy link
Collaborator

@kcz358 kcz358 commented Sep 12, 2024

Before you open a pull-request, please check if a similar issue already exists or has been closed before.

When you open a pull-request, please be sure to include the following

  • A descriptive title: [xxx] XXXX
  • A detailed description

Thank you for your contributions!


As stated in #243 , there is an error in current asyncio srt model. This PR tries to fix this and reproduce the result

@kcz358 kcz358 marked this pull request as draft September 12, 2024 03:41
@kcz358
Copy link
Collaborator Author

kcz358 commented Sep 12, 2024

The result can be reproduced now by srt model. The result are mostly aligned with the paper result.

Noted that current sglang main seems to have some issue and can not reproduce the result. I have checked that you are be able to reproduce the result by

cd sglang
git checkout 2f1d92834f41df42e266ed6d7036b4add906d21f

My current result using srt api model on llava-ov-0.5B

AI2D

image

MME

image

When using current main branch sglang, I can only get 216/1066 which is relatively low. I will try to check what changes in sglang caused this issue.

@kcz358 kcz358 marked this pull request as ready for review September 12, 2024 04:49
@kcz358 kcz358 requested a review from Luodian September 12, 2024 05:00
@Luodian Luodian merged commit d9d07e7 into main Sep 12, 2024
2 checks passed
@Luodian Luodian deleted the fix/srt_async branch September 12, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants