-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded Features #7
Open
frantiekm
wants to merge
19
commits into
Evolveum:master
Choose a base branch
from
inalogy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
b45798e
feature(whole app): Adding new classes + data to be generated
matejglombik a6bae0a
feat(Notifications): implemetning notification generating
matejglombik 557feb2
upgrade(midpoint version): from midpoint 4.4.1 -> 4.8
matejglombik 650331f
feat(Archetypes): Adding archetypes
matejglombik e924d6e
feat(lookUpTables): Adding lookUpTable section
matejglombik 33270cc
feat(Notifications): implementing notification section
matejglombik cabd077
fix(Export): fixing PDF export overlaying
matejglombik ea94de1
feat(CSS style): Adding css style
matejglombik ba89ae4
feat(whole app): Dynamic references
matejglombik 93ee9cd
feat(Policies): Implementing security/value policies
matejglombik fa78e3a
fix(resouce): creating empty table fix
matejglombik 0a19c15
fix(pdf file): customization
matejglombik 13dbf56
fix(user): removing password
matejglombik 5e32196
fix(property naming):
matejglombik 5147f97
refactor(exporter): HTML exporter - styling
matejglombik e7715f6
feat(Readme): Adding how to handle midscribe + more use cases
matejglombik 2e7d1a1
Merge remote-tracking branch 'upstream/master'
matejglombik bb25b40
fix(fixing issues): Errors correlated to merging evolveum midscribe i…
matejglombik b54fd6b
fix(removing) - css file
matejglombik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you switch to external command? Asciidoctor supports export to PDF, this creates dependency on another binary that might not be available. Native PDF export via asciidoctor is preferred, in case prince is needed then I'd expected user will use html export and then prince command separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main problem with the asciidoctor PDF export was formatting problem. Most of the generated documentation was unusable. The problem was that it did not recognize when the generated expression was ending therefore if the expression was longer and appeared on the next page it was overlapped with other sections. Use of the prince fixed that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matejglombik I understand but can't accept 3rd party dependency this way. If I understand it correctly prince can be still used with
midscribe --output-format html --output document.html;
and thenprince document.html document.pdf
. We can rather try to fix pdf generator later to get rid of prince altogether.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matejglombik I've created some simple test with resource object that contains long groovy script (in terms of line count and line length), midscribe rendered pdf where script just truncated and didn't continue to next page, lines breaks were created correctly. Could you provide (send) xml that creates incorrect output please?