К #1332: исправления функций работы с XML, с тестами #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Можно и перенести, смотря какую часть. Я бы в 1.8.4 все-таки не переносил бы, т.к. уже хочу выпустить |
EvilBeaver
reviewed
Sep 22, 2023
| throw RuntimeException.InvalidArgumentValue(); | ||
| try | ||
| { | ||
| var enumerationContext = GlobalsHelper.GetEnum(enumType); |
There was a problem hiding this comment.
Если я ничего не путаю, то public static IAttachableContext CreateInstance() вызывается с помощью инжектора зависимостей, и в него можно закинуть GlobalsManager и ITypeManager, а не пользоваться статиками
EvilBeaver
reviewed
Sep 23, 2023
| { | ||
| return new XmlGlobalFunctions(); | ||
| return new XmlGlobalFunctions(mgr); |
EvilBeaver
approved these changes
Sep 23, 2023
Mr-Rm
added a commit
to Mr-Rm/OneScript
that referenced
this pull request
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В v2
DefaultTypeManagerне статический, поэтому контекст перечислений не определяется заранее, а вычисляется при вызовеXMLЗначениеНе перенести ли часть решений из v2 в v1? Хотя бы добавить
DataType.Null