Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Рефлектор возвращает приватные поля и методы #1242

Merged
merged 8 commits into from
Jan 12, 2023

Conversation

Absolemus
Copy link
Contributor

No description provided.

src/ScriptEngine/Machine/Contexts/ScriptDrivenObject.cs Outdated Show resolved Hide resolved
src/ScriptEngine/Machine/LoadedModule.cs Outdated Show resolved Hide resolved
tests/reflector.os Outdated Show resolved Hide resolved
@Absolemus Absolemus changed the title Рефлектор возвращает приватные поля и методы Рефлектор возвращает приватные поля и методы issue #1235 Jan 3, 2023
@Absolemus Absolemus changed the title Рефлектор возвращает приватные поля и методы issue #1235 Рефлектор возвращает приватные поля и методы issue Jan 3, 2023
@Absolemus Absolemus changed the title Рефлектор возвращает приватные поля и методы issue Рефлектор возвращает приватные поля и методы Jan 3, 2023
src/ScriptEngine.HostedScript/Library/Reflector.cs Outdated Show resolved Hide resolved
src/ScriptEngine/Compiler/Compiler.cs Outdated Show resolved Hide resolved
src/ScriptEngine/Machine/Core.cs Show resolved Hide resolved
tests/reflector.os Show resolved Hide resolved
tests/reflector.os Show resolved Hide resolved
tests/reflector.os Outdated Show resolved Hide resolved
Copy link
Owner

@EvilBeaver EvilBeaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Огромная просьба упростить метод и если удастся - сразу починить и #1248.

src/ScriptEngine/Compiler/Compiler.cs Outdated Show resolved Hide resolved
@EvilBeaver EvilBeaver added this to the Версия 1.8.2 milestone Jan 10, 2023
Copy link
Owner

@EvilBeaver EvilBeaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо! Я готов влить, но если есть желание поправить 2 мелких замечания, я подожду.

bool exceptionThrown = false;
try
{
_ = host.Engine.GetCompilerService().Compile(moduleSource);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Странно, что здесь присваивание. Ведь можно же просто вызвать функцию, как процедуру

host.Engine.GetCompilerService().Compile(moduleSource);

{
var moduleSource = host.Engine.Loader.FromString(
@"Процедура Проц1()
Перем Переменная Экспорт;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Съехали отступы (лучше использовать пробелы, меньше проблем)

@Absolemus
Copy link
Contributor Author

Да, давай поправлю

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants