-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Рефлектор возвращает приватные поля и методы #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Огромная просьба упростить метод и если удастся - сразу починить и #1248.
Так же исправил ошибку #1248
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Спасибо! Я готов влить, но если есть желание поправить 2 мелких замечания, я подожду.
src/NUnitTests/CompilerTests.cs
Outdated
bool exceptionThrown = false; | ||
try | ||
{ | ||
_ = host.Engine.GetCompilerService().Compile(moduleSource); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Странно, что здесь присваивание. Ведь можно же просто вызвать функцию, как процедуру
host.Engine.GetCompilerService().Compile(moduleSource);
src/NUnitTests/CompilerTests.cs
Outdated
{ | ||
var moduleSource = host.Engine.Loader.FromString( | ||
@"Процедура Проц1() | ||
Перем Переменная Экспорт; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Съехали отступы (лучше использовать пробелы, меньше проблем)
Да, давай поправлю |
No description provided.