Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add overloading to googleAnalytics.set #178

Conversation

greatSumini
Copy link
Member

Description

googleAnalytics helper의 set 함수에 overloading을 추가했습니다.
이제 build결과 type declaration 파일이 아래처럼 생성되고, 함수 사용시 선택지가 보기 좋게 나옵니다!

Screen Shot 2021-08-30 at 12 20 21 AM

Screen Shot 2021-08-30 at 12 21 22 AM

Screen Shot 2021-08-30 at 12 21 26 AM

Help Wanted 👀

Related Issues

resolve #
fix #

Checklist ✋

  • PR 타이틀을 {PR type}: {PR title}로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)
  • 모든 변경점들을 확인했으며 적절히 설명했습니다.
  • 빌드와 테스트가 정상적으로 수행됨을 확인했습니다. (npm run build, npm run test)
  • 깃헙 이슈를 연결하겠습니다. (커밋에 resolve #이슈넘버 적거나 PR생성 후 Linked Issue 추가)

@greatSumini greatSumini added the enhancement New feature or request label Aug 29, 2021
@greatSumini greatSumini self-assigned this Aug 29, 2021
Copy link
Member

@hy57in hy57in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 checklist도 수정되었네요! LGTM👊🏻

Copy link
Member

@uoon-dev uoon-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~!! 🎃

@greatSumini greatSumini merged commit d381609 into EveryAnalytics:main Aug 30, 2021
@greatSumini greatSumini deleted the refactor/add-overloading-to-ga-set branch August 30, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants