Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/add stem controls #5

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Feat/add stem controls #5

merged 11 commits into from
Jul 31, 2024

Conversation

Eve00000
Copy link
Owner

No description provided.

@acolombier
feat: add basic COs and UI for STEM file
e6d4a2a 
Allow volume control of stem channels as well as basic UI feedback and
control
@acolombier
feat: add a simple stem waveform renderer
a85964c
@acolombier
feat: add UI control for stem
d14d0db 
Add a simplame and naive floating widget above the waveform
to control the stem volumes and get visual feedback of mute state
@acolombier
feat: add UI for stem on QML
36af073 
Switch the equalizer mixer to stem control if the deck is loaded with a
stem file
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9929946085

Details

  • 53 of 443 (11.96%) changed or added relevant lines in 22 files are covered.
  • 23 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.08%) to 31.747%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/qml/qmlplayerproxy.h 0 2 0.0%
src/skin/legacy/tooltips.cpp 0 2 0.0%
src/waveform/renderers/allshader/waveformrendermark.cpp 0 2 0.0%
src/waveform/waveform.h 0 2 0.0%
src/waveform/widgets/allshader/waveformwidget.cpp 0 2 0.0%
src/widget/wwaveformviewer.h 0 2 0.0%
src/waveform/renderers/allshader/waveformrendererfiltered.cpp 0 3 0.0%
src/waveform/renderers/allshader/waveformrendererhsv.cpp 0 3 0.0%
src/waveform/renderers/allshader/waveformrendererrgb.cpp 0 3 0.0%
src/waveform/renderers/allshader/waveformrenderertextured.cpp 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
src/skin/legacy/legacyskinparser.cpp 1 0.0%
src/preferences/dialog/dlgprefmixer.cpp 1 0.0%
src/mixer/basetrackplayer.cpp 1 58.09%
src/engine/channels/enginedeck.cpp 2 58.5%
src/widget/wwaveformviewer.cpp 5 0.0%
src/waveform/renderers/allshader/rgbadata.h 13 0.0%
Totals Coverage Status
Change from base Build 9927591315: -0.08%
Covered Lines: 32996
Relevant Lines: 103934
💛 - Coveralls

@acolombier acolombier force-pushed the feat/add-stem-controls branch 3 times, most recently from eed35f2 to a17c578 Compare July 25, 2024 18:54
@acolombier @JoergAtGithub @daschuer
Apply suggestions from code review
de5bfaf 
Co-authored-by: JoergAtGithub <[email protected]>
Co-authored-by: Daniel Schürmann <[email protected]>
@acolombier acolombier force-pushed the feat/add-stem-controls branch from a17c578 to de5bfaf Compare July 25, 2024 19:16
@acolombier acolombier force-pushed the feat/add-stem-controls branch from f5f6dd9 to ffeca7e Compare July 30, 2024 07:56
@acolombier acolombier force-pushed the feat/add-stem-controls branch from 2a3b142 to 0a4ba6d Compare July 30, 2024 19:03
@Eve00000 Eve00000 merged commit 9b31059 into Eve00000:main Jul 31, 2024
1 check passed
Eve00000 pushed a commit that referenced this pull request Feb 15, 2025
@JoergAtGithub
Updated 2.5 buildenv to build with libdjinterop 0.24.3 (#5)
778ba6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analyzer build code quality controller backend controller mappings engine library preferences qml skins ui waveform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eve00000 @coveralls @acolombier