Fix displaying progress in non-ansi terminal (microsoft#4320)

Evangelink · Dec 11, 2024 · 88286f6 · 88286f6
1 parent 23321d7
commit 88286f6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/NonAnsiTerminal.cs b/src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/NonAnsiTerminal.cs
@@ -183,8 +183,6 @@ public void RenderProgress(TestProgressState?[] progress)
 
             // Use just ascii here, so we don't put too many restrictions on fonts needing to
             // properly show unicode, or logs being saved in particular encoding.
-            TestDetailState? activeTest = p.TestNodeResultsState?.GetFirstRunningTask();
-            string? detail = !RoslynString.IsNullOrWhiteSpace(activeTest?.Text) ? $"- {activeTest.Text}" : null;
             Append('[');
             SetColor(TerminalColor.DarkGreen);
             Append('+');
@@ -226,10 +224,12 @@ public void RenderProgress(TestProgressState?[] progress)
                 Append(')');
             }
 
-            if (!RoslynString.IsNullOrWhiteSpace(detail))
+            TestDetailState? activeTest = p.TestNodeResultsState?.GetRunningTasks(1).FirstOrDefault();
+            if (!RoslynString.IsNullOrWhiteSpace(activeTest?.Text))
             {
                 Append(" - ");
-                Append(detail);
+                Append(activeTest.Text);
+                Append(' ');
             }
 
             Append(durationString);

diff --git a/src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestNodeResultsState.cs b/src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestNodeResultsState.cs
@@ -28,8 +28,6 @@ public TestNodeResultsState(long id)
 
     public void RemoveRunningTestNode(string uid) => _testNodeProgressStates.TryRemove(uid, out _);
 
-    public TestDetailState? GetFirstRunningTask() => _testNodeProgressStates.FirstOrDefault().Value;
-
     public IEnumerable<TestDetailState> GetRunningTasks(int maxCount)
     {
         var sortedDetails = _testNodeProgressStates