-
Notifications
You must be signed in to change notification settings - Fork 175
Maintainer instructions: new language PRs
Evan Hahn edited this page Oct 25, 2017
·
1 revision
This is how the library's maintainers (just one person at the moment!) review pull requests that add new languages.
- Make sure the pull request has both language definitions and tests; ask for things that are missing.
- Make sure the new language code is correct in the list of ISO 639-1 codes. It should be two characters.
- Run each of the tests through Google Translate to make sure nothing offensive is present in the submission.
- Review the code.
- Merge the pull request and thank the author. If it wasn't added to the credits list, you can ask them how they'd like to be credited.
- Deploy a new version of the library, typically with a minor version bump.