-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arabic translation enhancement: Hide unit count with dual forms. #222
Conversation
Thank you! I will take a look soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
I don't know much about Arabic. Do you have a place I could learn more about these rules to make sure this is correct for all Arabic speakers?
-
Please run
npm format
to format the code. -
It looks like tests are failing. Could you run
npm test
to make the tests pass?
@EvanHahn Thanks for your review! I'm working work on it!
I didn't find many English resources talking about the dual nouns (Muthanna) in Arabic, but this can help I guess. A noun that ends with "ين" or "ان" is a dual noun; that's why we never put a number before it. |
Thanks! I'll take another look soon. |
See [#222](#222). Co-Authored-By: Evan Hahn <[email protected]>
This was released in |
You're welcome! |
See [EvanHahn#222](EvanHahn#222). Co-Authored-By: Evan Hahn <[email protected]>
The issue with is described in #221.
I have implemented a solution for it.
Adds a property to the Arabic humanizer called
hideUnitInDualForm
that I used to indicate that the language is Arabic.Adds a new option, which is
arabic_hideUnitInDualForm
, it works only with Arabic language.default:
true
.I could just check if the language equals
ar
, but I thought it would be better to add thathideUnitInDualForm
property to the humanizer and options!