Use timezone aware datetime objects and use local time in webapp #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datetime.utcnow() is deprecated in 3.12 as it returns a naive datetime. Use timezone aware datetime objects internally. Pydantic serialization adds "Z" to timestamp in UTC timezone. To not brake current mobile clients, we should continue returning timestamp without timezone info. We use a custon PlainSerializer. Note that python isoformat() doesn't return "Z" but "+00:00".
zoneinfo was introduced in 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetime.utcnow()is deprecated in 3.12 as it returns a naive datetime.Use timezone aware datetime objects internally.
Pydantic serialization adds "Z" to timestamp in UTC timezone. To not brake current mobile clients, we continue returning timestamp without timezone info. We use a custom PlainSerializer. Note that python isoformat() doesn't return "Z" but "+00:00".
zoneinfowas introduced in 3.9)