Update RTD Sphinx search-as-you-type plugin #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Search as you type pops up, but always seems to say no results found, even though I'm searching for things I know are there. Maybe it doesn't work correctly in pull requests? I'm not convinced, but I'm going to merge it, let the docs build, and see if it works in master. If it still doesn't work, I'll pull it out again. |
|
Search as you type is working in the docs now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTD sent me an email about a security issue with the Sphinx search-as-you-type plugin. I don't think it's a big deal in our static docs pages, but may as well update.
I've also added it to the plugins in config, which will hopefully mean we actually get search-as-you-type. 😕